search

kyonifer / koma

A scientific computing library for Kotlin. https://kyonifer.github.io/koma
Other
270 stars 23 forks source link

Added ndArrayOf() #73

Closed peastman closed 5 years ago

peastman commented 5 years ago

Implements #72.

kyonifer commented 5 years ago

Looks good here, thanks!

Resolving the conversation from #72, I think the easiest path is to have matrixOf implement the same signature as ndArrayOf, i.e. support optional shape arguments. Since the goal of matrixOf and ndArrayOf is to be Kotlin idiomatic, I think dropping the end syntax entirely makes sense, leaving it to be used in the mat[...] builder DSL only. I'll go ahead and merge this and make the changes to matrixOf separately.