kypvalanx / Foundry-VTT-StarWars-SagaEdition

25 stars 8 forks source link

[bug] [Foundry v. 9.269] [SWSE v. 0.5.42] damage doubling randomly #284

Closed marvinandroid01 closed 2 years ago

marvinandroid01 commented 2 years ago

When in combat, the system does not always double damage for natural 20s rolled, and sporadically doubles the damage for non-critical hits.

This is an example from last night's game, when a player rolled a natural 20: image image

And this is an example from one of my random mooks getting double damage when he shouldn't: image image (mook's levels are nonheroic 3, Scout 3, so the half heroic level is calculating correctly and then being doubled with the dice damage).

The appearance of the d20 icon next to the attack roll reveals when the damage has been doubled, but it appears randomly rather than marking a critical hit (as I assume it is supposed to do).

Thank you for looking into this! I'm sorry that I don't have the programming skills to assist further in debugging the issues, and I appreciate all the work done to get the game system as well-functioning as it is.

kypvalanx commented 2 years ago

this is a duplicate #272