search

kypvalanx / Foundry-VTT-StarWars-SagaEdition

25 stars 8 forks source link

Ability modifier not added to reflex defense #424

Closed vertigoogle closed 1 year ago

vertigoogle commented 1 year ago

image

The dex bonus is missing in this calculation. Suggestions on how to debug this are very welcome :)

vertigoogle commented 1 year ago

Just saw that the heroic level is also missing, isn't it?

TalonKetupa commented 1 year ago

Calculation for defense was finding a "max ref bonus to defense" of 0 from non armor item data and keeping it.

vertigoogle commented 1 year ago

Calculation for defense was finding a "max ref bonus to defense" of 0 from non armor item data and keeping it.

Thanks for the hint and the prepared patch. Do you think the missing heroic level is sourced by the same bug? Or maybe I am misinterpreting the rules here.

TalonKetupa commented 1 year ago

The missing heroic level is slightly different. The get heroicLevel calculation broke after the major overhaul that happened recently since the way class levels were stored changed dramatically.

vertigoogle commented 1 year ago

Thank you very much for the insights. I would propose to keep this issue to track the missing heroic level calculation.

vertigoogle commented 1 year ago

Fixed with https://github.com/kypvalanx/Foundry-VTT-StarWars-SagaEdition/releases/tag/0.7.11 Testing OK