search

kyranf / robotarmyfactorio

A mod to add robot troop units and perhaps associated support buildings and items to produce and control them.
MIT License
35 stars 11 forks source link

Unstable 0.5.0 Crash on Spawn and Map Tagging #174

Closed DanPli closed 2 years ago

DanPli commented 3 years ago

Current Factorio V 1.1.19 Robot Army 0.5.0 unstable branch

Crash the moment the robot assembler spawns out a battle droid ( I did not test any other droid types yet, but I have a hunch it wouldn't matter ). The droid was fed by a requester chest and a stack inserter, which was controlled by an activity controller wired to the assembler, chest and the inserter. (output signal "battle droid count" ) (inserter enable signal "battle droid count" < 10)

2021-02-10 20_14_20

I get a crash with a Robot army notice as soon as I place a tag in map view as well:

2021-02-10 20_27_42

Thanks :)

kyranf commented 3 years ago

Please try to pull the updated robolib/robotarmyhelpers.lua file and do the same test.

DanPli commented 3 years ago

After updating the helpers lua the spawning works without crashes. I also watched a battle droid gun down a tree that trapped it, heh :)

Adding a tag to the map crashes with this error: 2021-02-10 22_35_09

Adding a Droid Settings Module to the same assembler/activity module-circuit network immediately crashes with this: 2021-02-10 22_40_03

Thanks :)

kyranf commented 3 years ago

Cheers, I will be able to fix both of those later today. Thanks a lot!

On Wed, 10 Feb 2021, 13:51 DanPli, notifications@github.com wrote:

After updating the helpers lua the spawning works without crashes. I also watched a battle droid gun down a tree that trapped it, heh :)

Adding a tag to the map crashes with this error: [image: 2021-02-10 22_35_09] https://user-images.githubusercontent.com/11747043/107576170-12b3dd80-6bf1-11eb-9f99-783014ee9e3f.jpg

Adding a Droid Settings Module to the same assembler/activity module-circuit network immediately crashes with this: [image: 2021-02-10 22_40_03] https://user-images.githubusercontent.com/11747043/107576279-324b0600-6bf1-11eb-96d9-d7b5a30893ce.jpg

Thanks :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kyranf/robotarmyfactorio/issues/174#issuecomment-777055859, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4I4ZTMRC37QPRASZUOOOLS6L5VVANCNFSM4XNRE4SA .

kyranf commented 3 years ago

I have a potential fix just committed for the map tagging stuff. The assembler circuit network with more than 1 settings module is coming up soon.

Just to confirm, it's when you have a droid assembler and you have one settings module on it already, but you add a second one? Which scenario includes a counter module as well?

DanPli commented 3 years ago

I had a droid assembler, an activity module wired up to it and an inserter and then added a droid settings module to that. Crash happened upon clicking the wire from the settings module on to the assembler (same network / wire color).

Thanks :-)

kyranf commented 3 years ago

@DanPli okay, get the latest. It's all fixed, from my changes and testing just now.

kyranf commented 3 years ago

Also note I just moved a whole bunch of stuff out of the config file and into the proper Factorio "mod settings" interfaces, at game start-up (for droid health/damage scalars) and the ingame mod settings you can change in runtime. it's the global defaults for things like hunt radius and squad size for if you don't want to set each assembler with specific settings modules.

DanPli commented 3 years ago

Alright, sounds great. Will do!

Thank you my good sir!