search

kyren / hashlink

An updated version of linked-hash-map and friends
Apache License 2.0
98 stars 18 forks source link

Making the deserialization for LinkedHashMap generic for build hasher type #7

Closed robinbernon closed 3 years ago

robinbernon commented 3 years ago

Changing deserialization impl from LinkedHashMap<K, V> to LinkedHashMap<K, V, S>

kyren commented 3 years ago

Yeah, I think this looks good to me, I apologize for waiting so long on some of these PRs, I have been trying to catch up.

if anyone would like to reach out to me to share maintainership of this crate that would be welcome, but I'll try to keep up with this stuff more closely.

kyren commented 3 years ago

I have also gone ahead and made the deserialize implementation on LinkedHashSet generic in the same way in 5daeea983840248191194182dae40edfbee2cf2d.

PsiACE commented 3 years ago

@kyren If you want, I can help maintain this crate/repo. I currently maintain a derivative version of hashlink, thank you very much for your work.

kyren commented 3 years ago

@PsiACE that's very kind, actually let me think about this a bit more, if you could just keep reviewing PRs and commenting on / fixing issues then I'd feel comfortable adding you as a maintainer but I should probably do the responsible thing and only add people who have a bit of a history with the crate first? But I do appreciate the offer for help and you can still help!