Error Running the example, not all SDP Fields Provided

kyren / webrtc-unreliable

Just enough hacks to get unreliable unordered WebRTC data channels between a browser and a server

Other

394 stars 29 forks source link

Error Running the example, not all SDP Fields Provided #16

Closed Meeshbhoombah closed 3 years ago

Meeshbhoombah commented 3 years ago

When running the example, I'm met with an error as a response (as seen in the debug console).

error: error streaming the incoming SDP descriptor: not all SDP fields provided

jaburns commented 3 years ago

This happens to me on head of master (43527e9) as well, if I go back to the commit tagged v0.5.0 I no longer get this error.

kyren commented 3 years ago

This should be fixed by 49ed336

kyren commented 3 years ago

Actually no hold on, I may have tested this badly, still working on it..

kyren commented 3 years ago

Okay now it's fixed, by 70eb324b0f8ebc1de35bec6406003d5d6787f59f

I don't fully understand all the details of why this last change was required, the best I can figure was I was setting js event handlers after the event had already happened, but I'm still not totally sure. If anybody who is an actual javascript programmer and has actual knowledge of this wants to chime in that would be very welcome.

Meeshbhoombah commented 3 years ago

Thanks for the fix!