search

kyriesent / node-rtsp-stream

Stream any RTSP stream and output to websocket for consumption by jsmpeg (https://github.com/phoboslab/jsmpeg). HTML5 streaming video! Requires ffmpeg.
MIT License
451 stars 166 forks source link

how to set the ffmpegPath #22

Closed winifred-tb closed 4 years ago

winifred-tb commented 5 years ago

i will use it in electron , i want set the path , please help me

kyriesent commented 5 years ago

@ctrlMySoul this currently isn't an available option, but it would be easy to modify the path here:

https://github.com/kyriesent/node-rtsp-stream/blob/cbe8ad999bc794f95e7bd7816e5851310c0b0cfd/src/mpeg1muxer.coffee#L28

If you want to add an option to change the path, I'm open to pull requests. Hope this helps!

regisgrison commented 5 years ago

Hi,

I needed to set this path and also to override the "-f mpeg1video" parameter so I made some changes in my version.

I can submit this changes to you if want in a pull request. I made them in order to have backward compatibility.

kyriesent commented 5 years ago

@Noelfhim sorry for the delay, but if you're still open to making a pull request I'd be happy to review it. Thank you!!

shealan commented 4 years ago

@regisgrison could you submit a pull request? Setting the ffmpeg path would be invaluable for Electron developers that want to embed ffmpeg in their application binaries.

regisgrison commented 4 years ago

Sorry, I did not saw @kyriesent message.

Now I have to find the version where I made the changes. I'll try to do it as quick as possible.

shealan commented 4 years ago

@regisgrison thank you so much :)

regisgrison commented 4 years ago

Pull request done.

I did not commit -f override because it has changed since I did it and I don't think it was the change you asked for.

shealan commented 4 years ago

@regisgrison thank you!

kyriesent commented 4 years ago

Closed by #50