search

kyrill007 / loosejar

Automatically exported from code.google.com/p/loosejar
Apache License 2.0
23 stars 16 forks source link

mavenize the project #6

Closed yogeshrao closed 8 years ago

yogeshrao commented 8 years ago

Hi,

I wanted loosed jar as part of my automated build (based on maven) and realised its not part of mvn repo. I have gone ahead and mavenized the project in my repo, sending u a PR for the same.

BTW thank you for the project.

Regards, -Yogesh

yogeshrao commented 8 years ago

How does releasing the project on maven central sound to you? If yes i can hep fix that..

kyrill007 commented 8 years ago

I absolutely love this idea! Thanks for helping with that.

yogeshrao commented 8 years ago

Before I proceed on this. Since maven support is now available as part of loosejar

  1. can we remove ant now?
  2. remove lib directory?
  3. remove .idea directory?
kyrill007 commented 8 years ago

Sure, I am ok with completely Mavenizing it. :)

yogeshrao commented 8 years ago

What license is the project released under ? Is it Apache License version 2 ?

kyrill007 commented 8 years ago

Yes! Feel free to add the license text to the project. And again, thank you for your help!

yogeshrao commented 8 years ago

you are welcome.. having it part of central repo also helps me :)

btw the group id of the project would change to com.googlecode.loosejar and the artifact id would be loosejar,

yogeshrao commented 8 years ago

just curious would you be able to follow couple of steps mentioned here http://stackoverflow.com/questions/28846802/how-to-manually-publish-jar-to-maven-central, seems to me it would be better if the author did it.

I have made all the other changes and will raise a pull request for the same.

kyrill007 commented 8 years ago

I'll get to it this week, Yogesh.

Thanks again, man!

-K.

On Sun, Oct 2, 2016 at 11:48 AM, Yogesh Rao notifications@github.com wrote:

just curious would you be able to follow couple of steps mentioned here http://stackoverflow.com/questions/28846802/how-to- manually-publish-jar-to-maven-central, seems to me it would be better if the author did it.

I have made all the other changes and will raise a pull request for the same.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kyrill007/loosejar/issues/6#issuecomment-250977947, or mute the thread https://github.com/notifications/unsubscribe-auth/AAml0zGP3VHvw2rVZPjhm1f5lHCbBxcwks5qv9JdgaJpZM4JpT_X .

yogeshrao commented 8 years ago

Thanks Kyrill!

please let me know once the jar is available on maven central.

kyrill007 commented 8 years ago

It's just been released, Yogesh. Thanks for your help!

yogeshrao commented 8 years ago

Wow thats great news!!! Thank you ...