kyriv1980 / Dummy

0 stars 0 forks source link

New Discretization #10

Closed kyriv1980 closed 3 days ago

kyriv1980 commented 3 days ago

Imported from https://github.inl.gov/ncrc/subchannel/issues/10 : @moose-ncrc created issue at Nov 02, 2020 11:33AM MST:

In GitLab by @kyriv1980 on Nov 2, 2020, 11:33

10

  1. Remove calculation of enthalpy and fluid properties from the mass flow method.
  2. Make two new methods for calculating enthalpy and fluid properties.
  3. Introduce and implement a new friction factor method wherever friction factor is calculated.
  4. Reduce the calculation of the sum quantities per channel to just crossflows.
  5. Apply a new discretization of the governing equations that is compatible/similar with the COBRA-SCHEME approach.
  6. Remove un-needed solution vectors (member variables).
  7. Regold.

(Keep the same solution algorithm as the original with the stencil) This version of the code is an improvement than that on issue #11

This issue is worked on branch : new_discretization

kyriv1980 commented 3 days ago

@moose-ncrc commented at Nov 02, 2020 12:14PM MST:

In GitLab by @kyriv1980 on Nov 2, 2020, 12:14

mentioned in commit 13d6c2f905a578dfe0c130f149942e88d3d0ee71

kyriv1980 commented 3 days ago

@moose-ncrc commented at Nov 03, 2020 02:25PM MST:

In GitLab by @kyriv1980 on Nov 3, 2020, 14:25

mentioned in commit 6102d0fe74c09708a68bf9fc6962f70ea99dc5a0

kyriv1980 commented 3 days ago

@moose-ncrc commented at Nov 03, 2020 03:09PM MST:

In GitLab by @kyriv1980 on Nov 3, 2020, 15:09

mentioned in commit 631205a269f7e16d3007ad6629c2cea5fd622ac3

kyriv1980 commented 3 days ago

@moose-ncrc commented at Nov 08, 2020 05:27PM MST:

In GitLab by @kyriv1980 on Nov 8, 2020, 17:27

mentioned in commit 527f461f4210048b1543c4cd64b14b4bf076ee0c

kyriv1980 commented 3 days ago

@moose-ncrc commented at Nov 08, 2020 07:55PM MST:

In GitLab by @kyriv1980 on Nov 8, 2020, 19:55

mentioned in commit f2db0a924c377ef85c08f905a73c8953602fa5bd

kyriv1980 commented 3 days ago

@moose-ncrc commented at Nov 08, 2020 08:06PM MST:

In GitLab by @kyriv1980 on Nov 8, 2020, 20:06

mentioned in commit e1acf8d53ef106a13fec8e978f10b33363775978

kyriv1980 commented 3 days ago

@moose-ncrc commented at Nov 08, 2020 11:07PM MST:

In GitLab by @kyriv1980 on Nov 8, 2020, 23:07

mentioned in commit 79e510283530fe3f3303525fed648157909fcaac

kyriv1980 commented 3 days ago

@moose-ncrc commented at Nov 08, 2020 11:17PM MST:

In GitLab by @kyriv1980 on Nov 8, 2020, 23:17

mentioned in commit 4f0300b0c544813dc6624d6bc12d5fda662ed824

kyriv1980 commented 3 days ago

@moose-ncrc commented at Nov 08, 2020 11:19PM MST:

In GitLab by @kyriv1980 on Nov 8, 2020, 23:19

mentioned in commit bf8e7a486e1a4b5eccbccee4aaa4c45cc88fb3ea

kyriv1980 commented 3 days ago

@moose-ncrc commented at Nov 08, 2020 11:28PM MST:

In GitLab by @kyriv1980 on Nov 8, 2020, 23:28

mentioned in commit 6abee1b927d2fb64b05c37151d57e3579b50934e

kyriv1980 commented 3 days ago

@moose-ncrc commented at Nov 08, 2020 11:52PM MST:

In GitLab by @kyriv1980 on Nov 8, 2020, 23:52

mentioned in commit b79a448050edd4cc2a81be8d12061380be2e3e3f

kyriv1980 commented 3 days ago

@moose-ncrc commented at Dec 16, 2020 01:41PM MST:

In GitLab by @kyriv1980 on Dec 16, 2020, 13:41

mentioned in commit 3cf088ffe706a5baeb4f84ad31388a1addf98258

kyriv1980 commented 3 days ago

@moose-ncrc commented at Dec 22, 2020 12:32PM MST:

In GitLab by @kyriv1980 on Dec 22, 2020, 12:32

mentioned in commit 1d2221614654ae7aa0b6d5cd53b02ae4414c8a3b

kyriv1980 commented 3 days ago

@moose-ncrc commented at Dec 22, 2020 01:40PM MST:

In GitLab by @kyriv1980 on Dec 22, 2020, 13:40

mentioned in commit 66162065cb3e421bbe15055727b875a7e993365e

kyriv1980 commented 3 days ago

@moose-ncrc commented at Dec 22, 2020 02:12PM MST:

In GitLab by @kyriv1980 on Dec 22, 2020, 14:12

mentioned in commit 3b93a611372c6bfede873d5e797c915fe4c718e8

kyriv1980 commented 3 days ago

@moose-ncrc commented at Dec 22, 2020 02:38PM MST:

In GitLab by @kyriv1980 on Dec 22, 2020, 14:38

mentioned in commit 8a74f5bff9a707ca77c9beefaa36934adecef862

kyriv1980 commented 3 days ago

@moose-ncrc commented at Dec 27, 2020 01:01PM MST:

In GitLab by @kyriv1980 on Dec 27, 2020, 13:01

mentioned in commit 65cd5708ce3a2794ca9017347819aa6cc1d5b47f

kyriv1980 commented 3 days ago

@moose-ncrc commented at Jan 05, 2021 03:26PM MST:

In GitLab by @kyriv1980 on Jan 5, 2021, 15:26

mentioned in commit cdbca53709a6946ed799b1203c7a1881134fcecf

kyriv1980 commented 3 days ago

@moose-ncrc commented at Jan 06, 2021 09:32PM MST:

In GitLab by @kyriv1980 on Jan 6, 2021, 21:32

mentioned in commit a20d72fc3c2c1272d674e8a425d8f6eb7e616f20

kyriv1980 commented 3 days ago

@moose-ncrc commented at Jan 06, 2021 09:34PM MST:

In GitLab by @kyriv1980 on Jan 6, 2021, 21:34

mentioned in commit 7f2bbf1612118984bc8b720696a85de16b6b5002

kyriv1980 commented 3 days ago

@moose-ncrc commented at Jan 07, 2021 09:56AM MST:

In GitLab by @kyriv1980 on Jan 7, 2021, 09:56

mentioned in commit 565d51f3cfcb811857793fddc20803ad62ed2eb5

kyriv1980 commented 3 days ago

@moose-ncrc commented at Jan 07, 2021 10:23AM MST:

In GitLab by @kyriv1980 on Jan 7, 2021, 10:23

mentioned in commit ef8e8a5468e38934d15ea8020644f68b4839e1db

kyriv1980 commented 3 days ago

@moose-ncrc commented at Jan 07, 2021 10:35AM MST:

In GitLab by @kyriv1980 on Jan 7, 2021, 10:35

mentioned in commit 1afe9abce9c95b6021bb8e3f6ad22f791211b2d4

kyriv1980 commented 3 days ago

@moose-ncrc commented at Jan 07, 2021 11:17AM MST:

In GitLab by @andrsd on Jan 7, 2021, 11:17

mentioned in commit 7a01c907434c7cd84e2193a1bf037588a8d3e391

kyriv1980 commented 3 days ago

Issue closed at: Jan 16, 2023 06:58PM MST by @moose-ncrc