Adding sodium properties [!30 merged]

[kyriv1980]

Imported from https://github.inl.gov/ncrc/subchannel/issues/103 : @moose-ncrc created issue at Jan 18, 2021 08:43AM MST:

In GitLab by @andrsd on Jan 18, 2021, 08:43

Merges sodium-props -> devel

Closes #12

[kyriv1980]

@moose-ncrc commented at Jan 18, 2021 08:44AM MST:

In GitLab by @moosetest on Jan 18, 2021, 08:44

CIVET Testing summary for 8051761

Precheck : Failed : pre test
Test : Canceled by user
Test dbg : Canceled by user
Non unity build : Canceled by user

[kyriv1980]

@moose-ncrc commented at Jan 18, 2021 08:47AM MST:

In GitLab by @andrsd on Jan 18, 2021, 08:47

added 2 commits

• a2f88ad8 - Adding sodium fluid properties
• e79557e8 - Adding unit tests

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Jan 18, 2021 08:53AM MST:

In GitLab by @andrsd on Jan 18, 2021, 08:53

@aydinka This is the beginning of the MR that will add sodium properties.

There are 2 patches: one for the properties itself and one with unit test.

We need to do this to finish the work:

• implement mu_from_rho_T in PBSodiumFluidProperties.C
• implement T_from_p_h in PBSodiumFluidProperties.C (this one can be probably obtained by inverting h_from_p_T.
• add unit tests in unit/src/PBSodiumFluidPropertiesTest.C. There are some initial tests - all fail because they serve as an example how to test. So, pick a state to test the quantity you want and compare it with the known value. If you want to test multiple thermodynamical points, we can do that as well.

As usual, ping me for details. I know this is only a rough description of the work.

[kyriv1980]

@moose-ncrc commented at Jan 18, 2021 08:53AM MST:

In GitLab by @andrsd on Jan 18, 2021, 08:53

marked this merge request as draft

[kyriv1980]

@moose-ncrc commented at Jan 18, 2021 09:32AM MST:

In GitLab by @moosetest on Jan 18, 2021, 09:32

Job Test on 26cc343 wanted to post the following:

Code coverage: deleted

This comment will be updated on new commits.

[kyriv1980]

@moose-ncrc commented at Jan 18, 2021 09:32AM MST:

In GitLab by @moosetest on Jan 18, 2021, 09:32

CIVET Testing summary for e79557e

Precheck : Passed
Test : Failed : test unit
Test dbg : Failed : test unit (Invalidated)
Non unity build : Passed

[kyriv1980]

@moose-ncrc commented at Jan 24, 2021 10:14PM MST:

In GitLab by @aydinka on Jan 24, 2021, 22:14

added 1 commit

• 619a2203 - Missing properties are added to PBSodiumFluidProperties.C and unit test cases...

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Jan 24, 2021 10:15PM MST:

In GitLab by @moosetest on Jan 24, 2021, 22:15

CIVET Testing summary for 619a220

Precheck : Failed : clang format check (Invalidated)
Test : Canceled by user
Test dbg : Canceled by user
Non unity build : Canceled by user
App tests : Canceled by user

[kyriv1980]

@moose-ncrc commented at Jan 26, 2021 11:28PM MST:

In GitLab by @aydinka on Jan 26, 2021, 23:28

added 1 commit

• 6429f392 - The unit test cases created for sodium properties now pass the tests. Refs #4

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Jan 26, 2021 11:29PM MST:

In GitLab by @moosetest on Jan 26, 2021, 23:29

Job Precheck on 6429f39 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied deleted
You can directly apply the patch by running, in the top level of your repository:

curl -k -u <username> -s DELETED | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 395e547f5adf7946977296598be72cc5d0f22371

[kyriv1980]

@moose-ncrc commented at Jan 26, 2021 11:29PM MST:

In GitLab by @moosetest on Jan 26, 2021, 23:29

CIVET Testing summary for 6429f39

Precheck : Failed : clang format check
Test : Canceled by user
Test dbg : Canceled by user
Non unity build : Canceled by user
App tests : Canceled by user

[kyriv1980]

@moose-ncrc commented at Jan 27, 2021 07:13AM MST:

In GitLab by @andrsd on Jan 27, 2021, 07:13

added 1 commit

• c49832cc - ++ clang-format

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Jan 27, 2021 07:33AM MST:

In GitLab by @moosetest on Jan 27, 2021, 07:33

CIVET Testing summary for c49832c

Precheck : Passed
Test : Passed (Invalidated)
Test dbg : Passed
Non unity build : Passed
App tests : Passed

[kyriv1980]

@moose-ncrc commented at Jan 27, 2021 11:20AM MST:

In GitLab by @andrsd on Jan 27, 2021, 11:20

marked this merge request as ready

[kyriv1980]

@moose-ncrc commented at Jan 27, 2021 12:13PM MST:

In GitLab by @andrsd on Jan 27, 2021, 12:13

added 4 commits

• c49832cc...fe558efc - 3 commits from branch devel
• 26cc343f - Adding sodium fluid properties

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Jan 27, 2021 12:16PM MST:

In GitLab by @andrsd on Jan 27, 2021, 12:16

enabled an automatic merge when the pipeline for 26cc343fd04237917ac54a834bd1384b1e674c29 succeeds

[kyriv1980]

@moose-ncrc commented at Jan 27, 2021 12:52PM MST:

In GitLab by @andrsd on Jan 27, 2021, 12:52

mentioned in commit 4f136a3e54d77ad8bcd89c03ac5e9c435091c03e

[kyriv1980]

@moose-ncrc commented at Jan 27, 2021 12:52PM MST:

In GitLab by @moosetest on Jan 27, 2021, 12:52

CIVET Testing summary for 26cc343

Precheck : Passed
Test : Passed
Test dbg : Passed
Non unity build : Passed
App tests : Passed

[kyriv1980]

Issue closed at: Jan 16, 2023 07:03PM MST by @moose-ncrc