search

kyriv1980 / Dummy

0 stars 0 forks source link

Breakup Methods #11

Closed kyriv1980 closed 3 days ago

kyriv1980 commented 3 days ago

Imported from https://github.inl.gov/ncrc/subchannel/issues/11 : @moose-ncrc created issue at Dec 20, 2020 11:38AM MST:

In GitLab by @kyriv1980 on Dec 20, 2020, 11:38

11

I want to break up and edit the methods without changing the discretized equations like I did in #10.

  1. Remove calculation of enthalpy and fluid properties from the mass flow method.
  2. Make two new methods for calculating enthalpy and fluid properties.
  3. Introduce and implement a new friction factor method wherever friction factor is calculated.
  4. Delete un-needed solution vectors. (member variables)
  5. Regold.

(Keep the same solution algorithm as the original with the stencil)

This issue is worked on branch : v_kyr1ak/breakup_methods

kyriv1980 commented 3 days ago

@moose-ncrc commented at Dec 20, 2020 12:40PM MST:

In GitLab by @kyriv1980 on Dec 20, 2020, 12:40

mentioned in commit 7e459dd718f81eb571f6842b96c4ca52bbc3b5b5

kyriv1980 commented 3 days ago

@moose-ncrc commented at Dec 20, 2020 01:02PM MST:

In GitLab by @kyriv1980 on Dec 20, 2020, 13:02

mentioned in commit 44611cf312605f39fbde157a3fc4367e35f19288

kyriv1980 commented 3 days ago

@moose-ncrc commented at Dec 20, 2020 01:18PM MST:

In GitLab by @kyriv1980 on Dec 20, 2020, 13:18

mentioned in commit 7986454333ab2951e57adc188a7ba757f39b3903

kyriv1980 commented 3 days ago

@moose-ncrc commented at Dec 20, 2020 01:33PM MST:

In GitLab by @kyriv1980 on Dec 20, 2020, 13:33

mentioned in commit 30e90f1c5b572c0925ccc3969f3af1f9d4d277f5

kyriv1980 commented 3 days ago

@moose-ncrc commented at Dec 20, 2020 02:22PM MST:

In GitLab by @kyriv1980 on Dec 20, 2020, 14:22

mentioned in commit dfd476f18945a354b75ab0cc77030be9a9c506f0

kyriv1980 commented 3 days ago

@moose-ncrc commented at Jan 06, 2021 07:08AM MST:

In GitLab by @kyriv1980 on Jan 6, 2021, 07:08

mentioned in commit 23dbef194011c0e3629651122ebe209ba8b97ce6

kyriv1980 commented 3 days ago

@moose-ncrc commented at Jan 06, 2021 07:08AM MST:

In GitLab by @kyriv1980 on Jan 6, 2021, 07:08

mentioned in commit 91730b723f4138286310140e0343f3bc4f7b42d1

kyriv1980 commented 3 days ago

@moose-ncrc commented at Jan 06, 2021 07:08AM MST:

In GitLab by @kyriv1980 on Jan 6, 2021, 07:08

mentioned in commit 06f49b572339d7957ba43fca1d108b7b4c9286bb

kyriv1980 commented 3 days ago

@moose-ncrc commented at Jan 06, 2021 07:08AM MST:

In GitLab by @kyriv1980 on Jan 6, 2021, 07:08

mentioned in commit 7ccf4ed62232048f5d28c7f46c8b13b2e75f2d1d

kyriv1980 commented 3 days ago

@moose-ncrc commented at Jan 06, 2021 07:08AM MST:

In GitLab by @kyriv1980 on Jan 6, 2021, 07:08

mentioned in commit 1cfe3dbc7b781e513cdf13399f23c2eb1626e8b6

kyriv1980 commented 3 days ago

Issue closed at: Jan 16, 2023 06:58PM MST by @moose-ncrc