Draft: Couple to Bison [!141 closed]

[kyriv1980]

Imported from https://github.inl.gov/ncrc/subchannel/issues/212 : @moose-ncrc created issue at Feb 11, 2022 02:15PM MST:

In GitLab by @kyriv1980 on Feb 11, 2022, 14:15

_Merges v_kyr1ak/couple_toBISON -> devel

This merge will resolve issue #53

[kyriv1980]

@moose-ncrc commented at Feb 11, 2022 02:15PM MST:

In GitLab by @kyriv1980 on Feb 11, 2022, 14:15

requested review from @andrsd

[kyriv1980]

@moose-ncrc commented at Feb 11, 2022 02:44PM MST:

In GitLab by @moosetest on Feb 11, 2022, 14:44

Job Test on 78f97d3 wanted to post the following:

View the site here

This comment will be updated on new commits.

[kyriv1980]

@moose-ncrc commented at Feb 11, 2022 02:44PM MST:

In GitLab by @moosetest on Feb 11, 2022, 14:44

Job Coverage on 78f97d3 wanted to post the following:

Coverage

	3238d5	#141 78f97d
	Total	Total	+/-	New
Rate	84.86%	82.22%	-2.64%	45.41%
Hits	2713	2816	+103	104
Misses	484	609	+125	125

Diff coverage report

Full coverage report

Warnings

• New new line coverage rate 45.41% is less than the suggested 90.0%

This comment will be updated on new commits.

[kyriv1980]

@moose-ncrc commented at Feb 11, 2022 02:46PM MST:

In GitLab by @moosetest on Feb 11, 2022, 14:46

CIVET Testing summary for 57e6def

Precheck : Passed
Test : Passed
Test dbg : Passed
Non unity build : Passed
App tests : Passed
Coverage : Failed : verify coverage

[kyriv1980]

@moose-ncrc commented at Feb 14, 2022 08:29AM MST:

In GitLab by @andrsd on Feb 14, 2022, 08:29

New new line coverage rate 8.73% is less than the suggested 90.0%

Build tests for the new code. Example is fine, but on those we only check syntax. You need to build regression tests for any new functionality.

[kyriv1980]

@moose-ncrc commented at Feb 14, 2022 11:25AM MST:

In GitLab by @kyriv1980 on Feb 14, 2022, 11:25

How to I make the test not fail when I get:

test:problems/coupling.bison: *** ERROR ***
test:problems/coupling.bison: The following warning occurred in the object "DefaultElementQuality_ElementQualityCheckerUserObject", of type "ElementQua
lityChecker".
test:problems/coupling.bison:
test:problems/coupling.bison: List of failed element IDs: 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,3
4,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71,72,73,74,75,76,77,78,79,80,81,82,83,84
,85,86,87,88,89,90,91,92,93,94,95,96,97,98,99,100,101,102,103,104,105,106,107,108,109,110,111,112,113,114,115,116,117,118,119,120,121,122,123,124,125,1
26,127,128,129,130,131,132,133,134,135,136,137,138,139,140,141,142,143,144,145,146,147,148,149,150,151,152,153,154,155,156,157,158,159,160,161,162,163,
164,165,166,167,168,169,170,171,172,173,174,175,176,177,178,179,180,181,182,183,184,185,186,187,188,189,190,191,192,193,194,195,196,197,198,199
test:problems/coupling.bison:

Also for some reason the sodium-37pin.test1 also started to complain out of the blue:

 test:problems/sodium-37pin.test1: *** ERROR ***
test:problems/sodium-37pin.test1: The following warning occurred in the object "_ElementQualityCheckerUserObject", of type "ElementQualityChecker".
test:problems/sodium-37pin.test1:
test:problems/sodium-37pin.test1: Provided quality metric doesn't apply to following element type: EDGE2

[kyriv1980]

@moose-ncrc commented at Feb 14, 2022 01:45PM MST:

In GitLab by @andrsd on Feb 14, 2022, 13:45

Do NOT use BisonApp or anything BISON specific, the test system would not be able to use that. Use HeatConductionApp instead and use surrogate heat conduction problem instead of BISON input file.

[kyriv1980]

@moose-ncrc commented at Feb 14, 2022 01:55PM MST:

In GitLab by @kyriv1980 on Feb 14, 2022, 13:55

added 1 commit

• d26ac2b8 - Create examples/classes to accomplish 2-way coupling of Subchannel/Bison Refs #53

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Feb 14, 2022 02:24PM MST:

In GitLab by @moosetest on Feb 14, 2022, 14:24

CIVET Testing summary for d26ac2b

Precheck : Passed
Test : Failed : test subchannel
Test dbg : Failed : test subchannel
Non unity build : Passed
App tests : Passed
Coverage : Canceled by user

[kyriv1980]

@moose-ncrc commented at Feb 14, 2022 03:42PM MST:

In GitLab by @kyriv1980 on Feb 14, 2022, 15:42

added 1 commit

• d1e11b8e - Create examples/classes to accomplish 2-way coupling of Subchannel/Bison Refs #53

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Feb 14, 2022 03:44PM MST:

In GitLab by @kyriv1980 on Feb 14, 2022, 15:44

added 1 commit

• 2ef259db - Create examples/classes to accomplish 2-way coupling of Subchannel/Bison Refs #53

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Feb 14, 2022 03:44PM MST:

In GitLab by @moosetest on Feb 14, 2022, 15:44

CIVET Testing summary for d1e11b8

Precheck : Passed
Test : Canceled by user
Test dbg : Canceled by user
Non unity build : Canceled by user
App tests : Canceled by user
Coverage : Canceled by user

[kyriv1980]

@moose-ncrc commented at Feb 14, 2022 04:13PM MST:

In GitLab by @moosetest on Feb 14, 2022, 16:13

CIVET Testing summary for 2ef259d

Precheck : Passed
Test : Failed : test subchannel
Test dbg : Failed : test subchannel
Non unity build : Passed
App tests : Passed
Coverage : Canceled by user

[kyriv1980]

@moose-ncrc commented at Feb 14, 2022 04:22PM MST:

In GitLab by @kyriv1980 on Feb 14, 2022, 16:22

added 1 commit

• 95ff75e3 - Create examples/classes to accomplish 2-way coupling of Subchannel/Bison Refs #53

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Feb 14, 2022 04:54PM MST:

In GitLab by @moosetest on Feb 14, 2022, 16:54

CIVET Testing summary for 95ff75e

Precheck : Passed
Test : Failed : test subchannel
Test dbg : Failed : test subchannel
Non unity build : Passed
App tests : Passed
Coverage : Canceled by user

[kyriv1980]

@moose-ncrc commented at Feb 16, 2022 12:50PM MST:

In GitLab by @kyriv1980 on Feb 16, 2022, 12:50

added 3 commits

• 95ff75e3...4e688c63 - 2 commits from branch devel
• ad1babff - Merge branch 'devel' into v_kyr1ak/couple_to_BISON

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Feb 16, 2022 01:21PM MST:

In GitLab by @moosetest on Feb 16, 2022, 13:21

CIVET Testing summary for ad1babf

Precheck : Passed
Test : Failed : test subchannel
Test dbg : Failed : test subchannel
Non unity build : Passed
App tests : Allowed to fail : build pronghorn
Coverage : Canceled by user

[kyriv1980]

@moose-ncrc commented at Feb 16, 2022 01:42PM MST:

In GitLab by @kyriv1980 on Feb 16, 2022, 13:42

added 12 commits

• ad1babff...666495b7 - 11 commits from branch devel
• 885582e5 - update current branch

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Feb 16, 2022 02:23PM MST:

In GitLab by @moosetest on Feb 16, 2022, 14:23

CIVET Testing summary for 885582e

Precheck : Passed
Test : Failed : test subchannel
Test dbg : Failed : test subchannel
Non unity build : Passed
App tests : Allowed to fail : build pronghorn
Coverage : Canceled by user

[kyriv1980]

@moose-ncrc commented at Feb 18, 2022 01:47PM MST:

In GitLab by @kyriv1980 on Feb 18, 2022, 13:47

added 1 commit

• 296878a0 - update current branch

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Feb 18, 2022 02:21PM MST:

In GitLab by @moosetest on Feb 18, 2022, 14:21

CIVET Testing summary for 296878a

Precheck : Passed
Test : Failed : test distributed mesh
Test dbg : Passed
Non unity build : Passed
App tests : Allowed to fail : build pronghorn
Coverage : Canceled by user

[kyriv1980]

@moose-ncrc commented at Feb 18, 2022 02:40PM MST:

In GitLab by @kyriv1980 on Feb 18, 2022, 14:40

added 1 commit

• 4b05548a - update current branch

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Feb 18, 2022 03:14PM MST:

In GitLab by @moosetest on Feb 18, 2022, 15:14

CIVET Testing summary for 4b05548

Precheck : Passed
Test : Allowed to fail : build docs
Test dbg : Passed
Non unity build : Passed
App tests : Allowed to fail : build pronghorn
Coverage : Allowed to fail : generate coverage

[kyriv1980]

@moose-ncrc commented at Feb 21, 2022 08:16AM MST:

In GitLab by @andrsd on Feb 21, 2022, 08:16

I will add a patch to fix the doco generation (hopefully today) - it is caused by adding the HC module. It should be trivial...

[kyriv1980]

@moose-ncrc commented at Feb 21, 2022 08:27AM MST:

In GitLab by @andrsd on Feb 21, 2022, 08:27

added 1 commit

• f500c01d - fixup! Create examples/classes to accomplish 2-way coupling of Subchannel/Bison Refs #53

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Feb 21, 2022 08:27AM MST:

In GitLab by @andrsd on Feb 21, 2022, 08:27

marked this merge request as draft from f500c01dfcefcf8f232a7edea6d2b4b122a32305

[kyriv1980]

@moose-ncrc commented at Feb 21, 2022 08:59AM MST:

In GitLab by @moosetest on Feb 21, 2022, 08:59

CIVET Testing summary for f500c01

Precheck : Passed
Test : Passed
Test dbg : Passed
Non unity build : Passed
App tests : Allowed to fail : build pronghorn
Coverage : Allowed to fail : generate coverage

[kyriv1980]

@moose-ncrc commented at Feb 21, 2022 09:14AM MST:

In GitLab by @andrsd on Feb 21, 2022, 09:14

Pronghorn failure is not caused by this MR.

[kyriv1980]

@moose-ncrc commented at Feb 22, 2022 11:27AM MST:

In GitLab by @kyriv1980 on Feb 22, 2022, 11:27

added 1 commit

• 6fffb848 - Update test.i

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Feb 22, 2022 11:58AM MST:

In GitLab by @moosetest on Feb 22, 2022, 11:58

CIVET Testing summary for 6fffb84

Precheck : Passed
Test : Failed : test subchannel
Test dbg : Failed : test subchannel
Non unity build : Passed
App tests : Allowed to fail : build pronghorn
Coverage : Canceled by user

[kyriv1980]

@moose-ncrc commented at Feb 22, 2022 12:14PM MST:

In GitLab by @kyriv1980 on Feb 22, 2022, 12:14

added 1 commit

• 6654c5bc - Update test.i

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Feb 22, 2022 12:17PM MST:

In GitLab by @kyriv1980 on Feb 22, 2022, 12:17

added 1 commit

• 51cdc060 - Replace test_out.e

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Feb 22, 2022 12:17PM MST:

In GitLab by @moosetest on Feb 22, 2022, 12:17

CIVET Testing summary for 6654c5b

Precheck : Passed
Test : Canceled by user
Test dbg : Canceled by user
Non unity build : Canceled by user
App tests : Canceled by user
Coverage : Canceled by user

[kyriv1980]

@moose-ncrc commented at Feb 22, 2022 12:51PM MST:

In GitLab by @moosetest on Feb 22, 2022, 12:51

CIVET Testing summary for 51cdc06

Precheck : Passed
Test : Failed : test threads
Test dbg : Passed
Non unity build : Passed
App tests : Allowed to fail : build pronghorn
Coverage : Canceled by user

[kyriv1980]

@moose-ncrc commented at Feb 22, 2022 01:06PM MST:

In GitLab by @kyriv1980 on Feb 22, 2022, 13:06

added 1 commit

• ed30dd7b - Replace transient_out.e

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Feb 22, 2022 01:44PM MST:

In GitLab by @moosetest on Feb 22, 2022, 13:44

CIVET Testing summary for ed30dd7

Precheck : Passed
Test : Passed
Test dbg : Passed
Non unity build : Passed
App tests : Passed
Coverage : Allowed to fail : generate coverage

[kyriv1980]

@moose-ncrc commented at Feb 23, 2022 07:57AM MST:

In GitLab by @andrsd on Feb 23, 2022, 07:57

When you are ready and want me to review, click 'Mark as ready` in the title.

Otherwise this will look like a draft and I would ignore it :-)

[kyriv1980]

@moose-ncrc commented at Feb 23, 2022 10:13AM MST:

In GitLab by @kyriv1980 on Feb 23, 2022, 10:13

marked this merge request as ready

[kyriv1980]

@moose-ncrc commented at Feb 24, 2022 12:48PM MST:

In GitLab by @andrsd on Feb 24, 2022, 12:48

The commit history of this branch is horrid:

• the fixup patch (f500c01dfcefcf8f232a7edea6d2b4b122a32305) needs to be merged into (95ff75e34c4e8909869e5d33f1f4348541fe7f2f)
• No merge commits in feature branches (ad1babff279ec19bd6136f17a1ef68052132b188 is a merge commit).
• 6654c5bca26e297d0c73227b4b25aecb5c2add69 and 6fffb8482094209620d440b8bf74d679394c19e7 should be one patch
• 51cdc0609535d180e3d64587f8684c6e97e7f4a9 should be squashed into
• 4b05548aba340b5a40594ae71ba6183af48dfff6 useless commit message, it does multiple things: updating input files, adding a test for qprimeaux.

Rebasing your branch should fix all those. I would recommend that the branch will start with 6e2babab6123018529369ed6f30093030c4e3282, 17008a16668478b38bc4c9f52643ed2b60f2586b and 8ff37365e7bf8a7fa95aa4ba0decc63532ec25c1. Then, you can have a patch that adds the code + test for qprimeaux, then you can the rest in some organized way (like adding examples + testing their syntax, etc.).

It also seems that 6e2babab6123018529369ed6f30093030c4e3282 should be augmented by adding the test for the transfer.

[kyriv1980]

@moose-ncrc commented at Feb 24, 2022 01:38PM MST:

In GitLab by @kyriv1980 on Feb 24, 2022, 13:38

added 14 commits

• 84919ee0 - Create examples of coupling subchannel to bison/heatConduction Refs #53
• a0671820 - Empty dtors are no longer needed
• 4259de98 - Submodule update
• 354f1f24 - Converting DetailedQuadSubChannelMesh into DetailedQuadSubChannelMeshGenerator
• f6903183 - DetailedQuadSubChannelMeshGenerator: set block ID and block name
• 982c9fe3 - Adding detailed pin mesh generator for quadrilateral lattice
• 791371df - Check that QuadICs are used only with QuadMesh
• 840f55e8 - Check that TriICs are used only with TriMesh
• 37a55a80 - Submodule update
• 210b8437 - fixup! Create examples/classes to accomplish 2-way coupling of Subchannel/Bison Refs #53
• c96d4a78 - Update test.i
• dd6c0b5e - Update test.i
• 6a5191b8 - Replace test_out.e
• 06d5514d - Replace transient_out.e

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Feb 24, 2022 01:38PM MST:

In GitLab by @kyriv1980 on Feb 24, 2022, 13:38

marked this merge request as draft from 210b84372cc9add0e459da4bff06b2e849941896

[kyriv1980]

@moose-ncrc commented at Feb 24, 2022 01:39PM MST:

In GitLab by @moosetest on Feb 24, 2022, 13:39

CIVET Testing summary for 06d5514

Precheck : Failed : fetch and branch
Test : Canceled by user
Test dbg : Canceled by user
Non unity build : Canceled by user
App tests : Canceled by user
Coverage : Canceled by user

[kyriv1980]

@moose-ncrc commented at Feb 24, 2022 01:44PM MST:

In GitLab by @kyriv1980 on Feb 24, 2022, 13:44

added 2 commits

• e34d361e - fixup! Edit and regold examples/tests Refs #53
• 721ff0c3 - Replace transient_out.e

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Feb 24, 2022 01:44PM MST:

In GitLab by @moosetest on Feb 24, 2022, 13:44

CIVET Testing summary for 721ff0c

Precheck : Failed : fetch and branch
Test : Canceled by user
Test dbg : Canceled by user
Non unity build : Canceled by user
App tests : Canceled by user
Coverage : Canceled by user

[kyriv1980]

@moose-ncrc commented at Feb 24, 2022 01:46PM MST:

In GitLab by @kyriv1980 on Feb 24, 2022, 13:46

added 1 commit

• d664c46f - fixup! Edit and regold examples/tests Refs #53

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Feb 24, 2022 01:46PM MST:

In GitLab by @moosetest on Feb 24, 2022, 13:46

CIVET Testing summary for d664c46

Precheck : Failed : fetch and branch
Test : Canceled by user
Test dbg : Canceled by user
Non unity build : Canceled by user
App tests : Canceled by user
Coverage : Canceled by user

[kyriv1980]

@moose-ncrc commented at Feb 24, 2022 03:24PM MST:

In GitLab by @kyriv1980 on Feb 24, 2022, 15:24

added 1 commit

• 82413e0b - fixup! Edit and regold examples/tests Refs #53

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Feb 24, 2022 03:25PM MST:

In GitLab by @moosetest on Feb 24, 2022, 15:25

CIVET Testing summary for 82413e0

Precheck : Failed : fetch and branch
Test : Canceled by user
Test dbg : Canceled by user
Non unity build : Canceled by user
App tests : Canceled by user
Coverage : Canceled by user

[kyriv1980]

@moose-ncrc commented at Feb 24, 2022 03:34PM MST:

In GitLab by @kyriv1980 on Feb 24, 2022, 15:34

added 15 commits

• 82413e0b...666495b7 - 13 commits from branch devel
• 9415efde - Create examples of coupling subchannel to bison/heatConduction Refs #53
• 94942944 - fixup! Edit and regold examples/tests Refs #53

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Feb 24, 2022 03:55PM MST:

In GitLab by @kyriv1980 on Feb 24, 2022, 15:55

added 1 commit

• 240c1648 - fixup! Edit and regold examples/tests Refs #53

Compare with previous version