search

kyriv1980 / Dummy

0 stars 0 forks source link

Hexagonal Liquid Metal heat equation/Blockage validation [!182 merged] #251

Closed kyriv1980 closed 2 months ago

kyriv1980 commented 2 months ago

Imported from https://github.inl.gov/ncrc/subchannel/issues/253 : @moose-ncrc created issue at Dec 01, 2022 03:26PM MST:

In GitLab by @kyriv1980 on Dec 1, 2022, 15:26

Merges kyriv/build-docs2 -> devel

This merge addresses issues #71, #68.

In addition:

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 01, 2022 03:26PM MST:

In GitLab by @kyriv1980 on Dec 1, 2022, 15:26

requested review from @tanoret

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 01, 2022 03:26PM MST:

In GitLab by @moosetest on Dec 1, 2022, 15:26

CIVET Testing summary for debfeb9

Precheck : Failed : pre test
Test : Canceled by user
Test PETSc alt : Canceled by user
Test VTB : Canceled by user
Test dbg : Canceled by user
Non unity build : Canceled by user
App tests : Canceled by user
Coverage : Canceled by user

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 01, 2022 03:39PM MST:

In GitLab by @kyriv1980 on Dec 1, 2022, 15:39

added 1 commit

Compare with previous version

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 01, 2022 03:48PM MST:

In GitLab by @moosetest on Dec 1, 2022, 15:48

Job Test on 4fa13d0 wanted to post the following:

View the site here

This comment will be updated on new commits.

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 01, 2022 03:59PM MST:

In GitLab by @moosetest on Dec 1, 2022, 15:59

CIVET Testing summary for 098c9d7

Precheck : Passed
Test : Failed : test subchannel
Test PETSc alt : Failed : test subchannel
Test VTB : Allowed to fail : Test VTB
Test dbg : Passed
Non unity build : Passed
App tests : Passed
Coverage : Canceled by user

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 01, 2022 04:07PM MST:

In GitLab by @kyriv1980 on Dec 1, 2022, 16:07

added 1 commit

Compare with previous version

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 01, 2022 04:20PM MST:

In GitLab by @kyriv1980 on Dec 1, 2022, 16:20

added 1 commit

Compare with previous version

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 01, 2022 04:20PM MST:

In GitLab by @moosetest on Dec 1, 2022, 16:20

CIVET Testing summary for ded2eb8

Precheck : Passed
Test : Failed : test subchannel
Test PETSc alt : Failed : test subchannel
Test VTB : Allowed to fail : Test VTB
Test dbg : Passed
Non unity build : Canceled by user
App tests : Passed
Coverage : Canceled by user

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 01, 2022 04:30PM MST:

In GitLab by @moosetest on Dec 1, 2022, 16:30

Job Coverage on 4fa13d0 wanted to post the following:

Coverage

f9f3cf #182 4fa13d
Total Total +/- New
Rate 84.71% 84.86% +0.15% 97.81%
Hits 8185 8229 +44 134
Misses 1477 1468 -9 3

Diff coverage report

Full coverage report

This comment will be updated on new commits.

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 01, 2022 04:41PM MST:

In GitLab by @moosetest on Dec 1, 2022, 16:41

CIVET Testing summary for 9571d5d

Precheck : Passed
Test : Passed
Test PETSc alt : Passed
Test VTB : Allowed to fail : Test VTB
Test dbg : Passed
Non unity build : Passed
App tests : Passed
Coverage : Allowed to fail : generate coverage

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 01, 2022 04:48PM MST:

In GitLab by @kyriv1980 on Dec 1, 2022, 16:48

added 1 commit

Compare with previous version

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 01, 2022 05:10PM MST:

In GitLab by @moosetest on Dec 1, 2022, 17:10

CIVET Testing summary for 7b3acbf

Precheck : Passed
Test : Passed
Test PETSc alt : Passed
Test VTB : Allowed to fail : Test VTB
Test dbg : Passed
Non unity build : Passed
App tests : Passed
Coverage : Allowed to fail : generate coverage

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 08:50AM MST:

In GitLab by @kyriv1980 on Dec 5, 2022, 08:50

added 1 commit

Compare with previous version

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 09:10AM MST:

In GitLab by @moosetest on Dec 5, 2022, 09:10

CIVET Testing summary for ad95bbd

Precheck : Passed
Test : Passed
Test PETSc alt : Passed
Test VTB : Allowed to fail : Test VTB
Test dbg : Passed
Non unity build : Passed
App tests : Passed
Coverage : Allowed to fail : generate coverage

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 09:49AM MST:

In GitLab by @kyriv1980 on Dec 5, 2022, 09:49

added 1 commit

Compare with previous version

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 10:08AM MST:

In GitLab by @moosetest on Dec 5, 2022, 10:08

CIVET Testing summary for 921e0de

Precheck : Passed
Test : Failed : test subchannel
Test PETSc alt : Passed
Test VTB : Allowed to fail : Test VTB
Test dbg : Passed
Non unity build : Passed
App tests : Passed
Coverage : Canceled by user

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 10:33AM MST:

In GitLab by @kyriv1980 on Dec 5, 2022, 10:33

added 1 commit

Compare with previous version

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 10:53AM MST:

In GitLab by @moosetest on Dec 5, 2022, 10:53

CIVET Testing summary for 43374e4

Precheck : Passed
Test : Passed
Test PETSc alt : Passed
Test VTB : Allowed to fail : Test VTB
Test dbg : Passed
Non unity build : Passed
App tests : Passed
Coverage : Allowed to fail : generate coverage

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 11:08AM MST:

In GitLab by @kyriv1980 on Dec 5, 2022, 11:08

added 1 commit

Compare with previous version

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 11:27AM MST:

In GitLab by @moosetest on Dec 5, 2022, 11:27

CIVET Testing summary for 4fe05bd

Precheck : Passed
Test : Passed
Test PETSc alt : Passed
Test VTB : Allowed to fail : Test VTB
Test dbg : Passed
Non unity build : Passed
App tests : Passed
Coverage : Passed

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:09PM MST:

In GitLab by @tanoret on Dec 5, 2022, 15:09

Do you want to use std::abs to be consistent with other calls in the code?

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:09PM MST:

In GitLab by @tanoret on Dec 5, 2022, 15:09

Consider removing this commented block

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:09PM MST:

In GitLab by @tanoret on Dec 5, 2022, 15:09

This comment block should not be in the source code

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:09PM MST:

In GitLab by @tanoret on Dec 5, 2022, 15:09

This comment block should not be in the source code

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:09PM MST:

In GitLab by @tanoret on Dec 5, 2022, 15:09

Consider using std::abs for consistency

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:09PM MST:

In GitLab by @tanoret on Dec 5, 2022, 15:09

Consider using std::abs for consistency

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:09PM MST:

In GitLab by @tanoret on Dec 5, 2022, 15:09

Consider removing commented block out of the source code

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:09PM MST:

In GitLab by @tanoret on Dec 5, 2022, 15:09

Is is necessary to have this comment block printed every time? Can we make this optional with the verbose flag?

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:09PM MST:

In GitLab by @tanoret on Dec 5, 2022, 15:09

Nice work

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:31PM MST:

In GitLab by @kyriv1980 on Dec 5, 2022, 15:31

Done.

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:34PM MST:

In GitLab by @kyriv1980 on Dec 5, 2022, 15:34

removed commented block.

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:38PM MST:

In GitLab by @kyriv1980 on Dec 5, 2022, 15:38

removed print outs.

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:38PM MST:

In GitLab by @kyriv1980 on Dec 5, 2022, 15:38

removed print outs.

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:38PM MST:

In GitLab by @kyriv1980 on Dec 5, 2022, 15:38

done.

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:39PM MST:

In GitLab by @kyriv1980 on Dec 5, 2022, 15:39

done.

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:41PM MST:

In GitLab by @kyriv1980 on Dec 5, 2022, 15:41

removed commented section.

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:42PM MST:

In GitLab by @kyriv1980 on Dec 5, 2022, 15:42

Removed printouts.

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:42PM MST:

In GitLab by @kyriv1980 on Dec 5, 2022, 15:42

resolved all threads

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:43PM MST:

In GitLab by @kyriv1980 on Dec 5, 2022, 15:43

changed this line in version 10 of the diff

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:43PM MST:

In GitLab by @kyriv1980 on Dec 5, 2022, 15:43

changed this line in version 10 of the diff

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:43PM MST:

In GitLab by @kyriv1980 on Dec 5, 2022, 15:43

changed this line in version 10 of the diff

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:43PM MST:

In GitLab by @kyriv1980 on Dec 5, 2022, 15:43

changed this line in version 10 of the diff

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:43PM MST:

In GitLab by @kyriv1980 on Dec 5, 2022, 15:43

changed this line in version 10 of the diff

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:43PM MST:

In GitLab by @kyriv1980 on Dec 5, 2022, 15:43

changed this line in version 10 of the diff

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 03:43PM MST:

In GitLab by @kyriv1980 on Dec 5, 2022, 15:43

added 1 commit

Compare with previous version

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 04:04PM MST:

In GitLab by @moosetest on Dec 5, 2022, 16:04

CIVET Testing summary for 4fa13d0

Precheck : Passed
Test : Passed
Test PETSc alt : Passed
Test VTB : Allowed to fail : Test VTB
Test dbg : Passed
Non unity build : Passed
App tests : Passed
Coverage : Passed

kyriv1980 commented 2 months ago

@moose-ncrc commented at Dec 05, 2022 04:21PM MST:

In GitLab by @kyriv1980 on Dec 5, 2022, 16:21

mentioned in commit f094389996105ecb410d85105b482c041be86e60

kyriv1980 commented 2 months ago

Issue closed at: Jan 16, 2023 07:13PM MST by @moose-ncrc