Make modular [!5 merged]

[kyriv1980]

Imported from https://github.inl.gov/ncrc/subchannel/issues/78 : @moose-ncrc created issue at Sep 14, 2020 11:57AM MST:

In GitLab by @kyriv1980 on Sep 14, 2020, 12:57

_Merges makemodular -> devel

Closes issue #8

[kyriv1980]

@moose-ncrc commented at Oct 15, 2020 05:38PM MST:

In GitLab by @kyriv1980 on Oct 15, 2020, 18:38

Please be more specific?? What needs to change?

[kyriv1980]

@moose-ncrc commented at Oct 15, 2020 05:40PM MST:

In GitLab by @kyriv1980 on Oct 15, 2020, 18:40

Yes you are correct... this was a left over when I was trying to verify that I am reading that matrix correctly. I have removed the offending line.

[kyriv1980]

@moose-ncrc commented at Oct 15, 2020 05:43PM MST:

In GitLab by @kyriv1980 on Oct 15, 2020, 18:43

At this moment this is the last thing on my mind. Because the code has other issues that require fixing that are more important. Eventually it can be provided by the user but I am also wondering if the user should be able to do that?

[kyriv1980]

@moose-ncrc commented at Oct 15, 2020 05:48PM MST:

In GitLab by @kyriv1980 on Oct 15, 2020, 18:48

Done.

[kyriv1980]

@moose-ncrc commented at Oct 15, 2020 05:51PM MST:

In GitLab by @kyriv1980 on Oct 15, 2020, 18:51

This saves the crossflows after a steady state solution. When I do a null transient I want to import those crossflows. So I copy this file from the steady state example folder to the null-transient example folder. My null transient reads this file.

Because crossflows are no solution vectors like P_soln , mdot_soln and the rest I use this trick to import them.

[kyriv1980]

@moose-ncrc commented at Oct 15, 2020 05:53PM MST:

In GitLab by @moosetest on Oct 15, 2020, 18:53

CIVET Testing summary for 04e2482

Precheck : Passed
Test : Failed : generate code coverage
Test dbg : Failed : test subchannel
Non unity build : Passed

[kyriv1980]

@moose-ncrc commented at Oct 15, 2020 05:55PM MST:

In GitLab by @kyriv1980 on Oct 15, 2020, 18:55

I didn't change the number of tests that we were doing... I just made it more modular, but had to regold two tests cause I added a new solution vector DP_soln. So I have no idea why would that be a problem.

[kyriv1980]

@moose-ncrc commented at Oct 15, 2020 05:56PM MST:

In GitLab by @kyriv1980 on Oct 15, 2020, 18:56

changed this line in version 15 of the diff

[kyriv1980]

@moose-ncrc commented at Oct 15, 2020 05:56PM MST:

In GitLab by @kyriv1980 on Oct 15, 2020, 18:56

changed this line in version 15 of the diff

[kyriv1980]

@moose-ncrc commented at Oct 15, 2020 05:56PM MST:

In GitLab by @kyriv1980 on Oct 15, 2020, 18:56

changed this line in version 15 of the diff

[kyriv1980]

@moose-ncrc commented at Oct 15, 2020 05:56PM MST:

In GitLab by @kyriv1980 on Oct 15, 2020, 18:56

changed this line in version 15 of the diff

[kyriv1980]

@moose-ncrc commented at Oct 15, 2020 05:56PM MST:

In GitLab by @kyriv1980 on Oct 15, 2020, 18:56

added 1 commit

• fd1021e8 - various small edits based on latest branch review Refs #8

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Oct 15, 2020 06:28PM MST:

In GitLab by @moosetest on Oct 15, 2020, 19:28

CIVET Testing summary for fd1021e

Precheck : Passed
Test : Failed : test subchannel
Test dbg : Failed : test subchannel
Non unity build : Passed

[kyriv1980]

@moose-ncrc commented at Oct 16, 2020 07:21AM MST:

In GitLab by @andrsd on Oct 16, 2020, 08:21

We could set this to some default value and if we need to change it, it would be done via input file, not code.

Strictly speaking, we should explain every code change. Randomly changing tolerances is suspicious.

[kyriv1980]

@moose-ncrc commented at Oct 16, 2020 07:22AM MST:

In GitLab by @andrsd on Oct 16, 2020, 08:22

"turbulent Crossflow" -> "Turbulent crossflow"

[kyriv1980]

@moose-ncrc commented at Oct 16, 2020 07:23AM MST:

In GitLab by @andrsd on Oct 16, 2020, 08:23

Got ya, then this is fine.

[kyriv1980]

@moose-ncrc commented at Oct 16, 2020 07:24AM MST:

In GitLab by @andrsd on Oct 16, 2020, 08:24

Put this file in .gitignore and remove it from the MR. Similar to the other file below...

[kyriv1980]

@moose-ncrc commented at Oct 16, 2020 07:27AM MST:

In GitLab by @andrsd on Oct 16, 2020, 08:27

Ok, then, this is fine for right now, but we will need to improve this eventually.

[kyriv1980]

@moose-ncrc commented at Oct 16, 2020 07:31AM MST:

In GitLab by @andrsd on Oct 16, 2020, 08:31

Right. I have not seen you touched the test suite, so that's interesting. But, the generated code coverage report shows that we are not exercising the transfer to pretty mesh. We can merge this once fixed and then we can address the code coverage issue separately. I hope to exercise just the transfer (without solving anything)

[kyriv1980]

@moose-ncrc commented at Oct 20, 2020 12:47PM MST:

In GitLab by @andrsd on Oct 20, 2020, 13:47

changed this line in version 16 of the diff

[kyriv1980]

@moose-ncrc commented at Oct 20, 2020 12:47PM MST:

In GitLab by @andrsd on Oct 20, 2020, 13:47

changed this line in version 16 of the diff

[kyriv1980]

@moose-ncrc commented at Oct 20, 2020 12:47PM MST:

In GitLab by @andrsd on Oct 20, 2020, 13:47

changed this line in version 16 of the diff

[kyriv1980]

@moose-ncrc commented at Oct 20, 2020 12:47PM MST:

In GitLab by @andrsd on Oct 20, 2020, 13:47

added 11 commits

• fd1021e8...75f291c9 - 10 commits from branch devel
• ab615511 - Refactoring code to be more modular

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Oct 20, 2020 12:58PM MST:

In GitLab by @andrsd on Oct 20, 2020, 13:58

added 1 commit

• 4a65dd6d - Refactoring code to be more modular

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Oct 20, 2020 12:58PM MST:

In GitLab by @moosetest on Oct 20, 2020, 13:58

CIVET Testing summary for ab61551

Precheck : Passed
Test : Canceled by user
Test dbg : Canceled by user
Non unity build : Canceled by user

[kyriv1980]

@moose-ncrc commented at Oct 20, 2020 01:01PM MST:

In GitLab by @andrsd on Oct 20, 2020, 14:01

changed this line in version 18 of the diff

[kyriv1980]

@moose-ncrc commented at Oct 20, 2020 01:01PM MST:

In GitLab by @andrsd on Oct 20, 2020, 14:01

added 1 commit

• 15681918 - Refactoring code to be more modular

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Oct 20, 2020 01:01PM MST:

In GitLab by @moosetest on Oct 20, 2020, 14:01

CIVET Testing summary for 4a65dd6

Precheck : Passed
Test : Canceled by user
Test dbg : Canceled by user
Non unity build : Canceled by user

[kyriv1980]

@moose-ncrc commented at Oct 20, 2020 01:01PM MST:

In GitLab by @andrsd on Oct 20, 2020, 14:01

resolved all threads

[kyriv1980]

@moose-ncrc commented at Oct 20, 2020 01:01PM MST:

In GitLab by @andrsd on Oct 20, 2020, 14:01

enabled an automatic merge when the pipeline for 1568191820365b17d60ce79850277f31286ab104 succeeds

[kyriv1980]

@moose-ncrc commented at Oct 20, 2020 01:06PM MST:

In GitLab by @andrsd on Oct 20, 2020, 14:06

canceled the automatic merge

[kyriv1980]

@moose-ncrc commented at Oct 20, 2020 01:11PM MST:

In GitLab by @kyriv1980 on Oct 20, 2020, 14:11

Looks good

[kyriv1980]

@moose-ncrc commented at Oct 20, 2020 01:12PM MST:

In GitLab by @kyriv1980 on Oct 20, 2020, 14:12

approved this merge request

[kyriv1980]

@moose-ncrc commented at Oct 20, 2020 01:33PM MST:

In GitLab by @moosetest on Oct 20, 2020, 14:33

CIVET Testing summary for 1568191

Precheck : Passed
Test : Failed : test subchannel
Test dbg : Failed : test subchannel
Non unity build : Passed

[kyriv1980]

@moose-ncrc commented at Oct 20, 2020 01:44PM MST:

In GitLab by @andrsd on Oct 20, 2020, 14:44

resolved all threads

[kyriv1980]

@moose-ncrc commented at Oct 20, 2020 01:44PM MST:

In GitLab by @andrsd on Oct 20, 2020, 14:44

added 1 commit

• 5c5b8c6f - Refactoring code to be more modular

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Oct 20, 2020 02:14PM MST:

In GitLab by @moosetest on Oct 20, 2020, 15:14

CIVET Testing summary for 5c5b8c6

Precheck : Passed
Test : Allowed to fail : build docs
Test dbg : Failed : test subchannel
Non unity build : Passed

[kyriv1980]

@moose-ncrc commented at Oct 20, 2020 02:42PM MST:

In GitLab by @andrsd on Oct 20, 2020, 15:42

resolved all threads

[kyriv1980]

@moose-ncrc commented at Oct 20, 2020 02:42PM MST:

In GitLab by @andrsd on Oct 20, 2020, 15:42

added 1 commit

• 71a0e3e9 - Refactoring code to be more modular

Compare with previous version

[kyriv1980]

@moose-ncrc commented at Oct 20, 2020 03:10PM MST:

In GitLab by @moosetest on Oct 20, 2020, 16:10

CIVET Testing summary for 71a0e3e

Precheck : Passed
Test : Allowed to fail : build docs
Test dbg : Passed
Non unity build : Passed

[kyriv1980]

@moose-ncrc commented at Oct 20, 2020 03:21PM MST:

In GitLab by @andrsd on Oct 20, 2020, 16:21

mentioned in commit 0a1232181870bfc4cf873d666d194da5aa7af1eb

[kyriv1980]

Issue closed at: Jan 16, 2023 07:02PM MST by @moose-ncrc