search

kyro46 / assPaintQuestion

!ILIAS 8-Version requires testing! Questiontype that allows free painting on a browsercanvas in ILIAS 4.3 to 8
GNU General Public License v3.0
4 stars 2 forks source link

Wrong imagetype in export #26

Open Rillke opened 2 years ago

Rillke commented 2 years ago

The export defaults the imagetype to image/jpeg if the file does not end in gif or png.

However, you can upload foo.PNG. A perfectly valid PNG file that will be classified as <fieldlabel>imagetype</fieldlabel><fieldentry>image/jpeg</fieldentry> in the exported XML.

Maybe use gd here to determine the type as the rest of the plugin does or make the regexp case insensitive?

Rillke commented 2 years ago

also you don't really need the .* part of the regexp (as it basically says something or nothing; a never referenced ταυτολογία), do you?