search

kyro46 / assPaintQuestion

!ILIAS 8-Version requires testing! Questiontype that allows free painting on a browsercanvas in ILIAS 4.3 to 8
GNU General Public License v3.0
4 stars 2 forks source link

Question about strange includes #27

Closed Rillke closed 2 years ago

Rillke commented 2 years ago

Hi,

class.assPaintQuestionExport.php (and others) include_once themselves. What's the purpose of this?

kyro46 commented 2 years ago

In the named file are two includes. One for the ilXmlWriter to create the output and one for assQuestionExport for inheritance. I can't see what you mean, please name a line.

Rillke commented 2 years ago

I meant the first include but you are right, it's the inherited class. Btw, why is it included and not required?

https://github.com/kyro46/assPaintQuestion/blob/af09105db559eaf02f110516f73593f08c8ccd98/classes/export/qti12/class.assPaintQuestionExport.php#L3

kyro46 commented 2 years ago

ILIAS coding reference/style. Looking at the current core classes though, not entirely stringent, but seemingly still the majority.