kyroschow / BasementsandAndroids

1 stars 0 forks source link

"freetype" problem, gradles refuses to build #1

Closed kyroschow closed 6 years ago

kyroschow commented 6 years ago

possibly introduced by 893b5b8f9e0cd0c7c3180648060cef1eee1ab139

kyroschow commented 6 years ago

https://github.com/TheCompSciNoob/BasementsandAndroids/blob/a27def1a2bfa5fb276933b70139bbbc346eea995/build.gradle#L96 vs https://github.com/TheCompSciNoob/BasementsandAndroids/blob/7ab38f0b465cac7ad6880eca99f01a497ca1bbd2/build.gradle#L86

kyroschow commented 6 years ago

By the way, @hedgey579 are "repositories" and "dependencies" redundant because the code worked without them. https://github.com/TheCompSciNoob/BasementsandAndroids/blob/a27def1a2bfa5fb276933b70139bbbc346eea995/build.gradle#L129

alexanderberry commented 6 years ago

:thinking:

Not entirely sure why the code would work without them, because the repositories and dependencies blocks serve different functions. Defining a repositories block like the one here

https://github.com/TheCompSciNoob/BasementsandAndroids/blob/a27def1a2bfa5fb276933b70139bbbc346eea995/build.gradle#L129-L132

tells gradle where to get the dependencies defined under the dependencies block. I find it curious that gradle functions without the global repositories block, but my theory is that it's because we have individual repositories blocks in each of our module level build.gradle projects (see below for examples)

https://github.com/TheCompSciNoob/BasementsandAndroids/blob/1d8a5e23a2e7623595b5e5dd4b0c3ee14a6092c7/android/build.gradle#L140-L142

https://github.com/TheCompSciNoob/BasementsandAndroids/blob/1d8a5e23a2e7623595b5e5dd4b0c3ee14a6092c7/core/build.gradle#L25-L27

alexanderberry commented 6 years ago

Resolved by 7f146907f1dd7d5c7542e7bcbae7d4b86b4b3648