search

kyroschow / MinigameMarathon

0 stars 1 forks source link

BinaryGameFragment has unused time accesses #50

Closed alexanderberry closed 6 years ago

alexanderberry commented 6 years ago

Your issue may have already been reported! Please check the issue tracker before creating a new issue.

Expected behavior

BinaryGameFragment does not access time as its scoring system no longer requires it.

Actual behavior

BinaryGameFragment accesses the Stopwatch class through the GameContainerFragment class to retrieve time despite the fact that the value returned by GameContainerFragment is not used by BinaryGameFragment

Possible solution

Remove the lapTime variable in BinaryGameFragment and remove lines where it is written to or read from.

Steps to reproduce the behavior

Observe lines 49 and 230 in BinaryGameFragment.

Environment

Project Version (the hash of the commit where the issue ocurred): Development version 77638a7e30f036362f9b60779b0d60b15138b7be. OS Version (Version and API Level): Lollipop 5.0 (API Level 20) Platform (Device type): Nexus 7

alexanderberry commented 6 years ago

Resolved by 43acf47b2e048ad632caf498fc540ae9ea12da40.