search

kyrptonaught / DiggusMaximus

MIT License
25 stars 21 forks source link

Mod Menu custom groups config is limited to 32 Characters disabling ability to group blocks #44

Closed Drunkender closed 2 years ago

Drunkender commented 2 years ago

When trying to create a custom group in the mod menu(minecraft:iron_ore, minecraft:deepslate_iron_ore) it gets cut off at (minecraft:iron_ore, minecraft:de). When I manually add it to the grouping.json5 file they will still not excavate together.

Minecraft 1.18.1, fabric 0.12.12, DiggusMaximus 1.5.2-1.18

https://i.imgur.com/gAHMaJC.png config_file

https://i.imgur.com/hbNV8FX.png mod_menu

Drunkender commented 2 years ago

I've also tried enabling Tag Grouping like your example here to no avail.

kyrptonaught commented 2 years ago

I redid the grouping config option in mod menu to make it a bit easier to use. This does increase the limit too. I'll get this released soon

image

Drunkender commented 2 years ago

Nice! Thank you very much. Block grouping was one of my favorite features of the Ore Excavation mod for Forge. Would love to see it working in DiggusMaximus aswell!

Cheers

kyrptonaught commented 2 years ago

Here is a pre-release

diggusmaximus-1.5.3-1.18.zip

Drunkender commented 2 years ago

Works perfectly! Although I found a way to crash it already =D. Pasting the results from /ct hand( * 64) into the block group gave me this. (Was doing this to add new blocks quickly from the dense ores mod)

---- Minecraft Crash Report ---- // Daisy, daisy...

Time: 1/31/22, 9:40 PM Description: Rendering screen

net.minecraft.class151: Non [a-z0-9.-] character in namespace of location: * 64

If you want the whole stack trace let me know. Other than that hiccup I love it!

kyrptonaught commented 2 years ago

You need to remove the * 64. The block listed should only be it's ID. But It shouldn't crash, that should be fixed

Drunkender commented 2 years ago

I was planning on editing it in the config screen, it was just a fast way to get the item id. Had all of the iron ores and dense iron ores in one block group.

Thank you very much for this!