search

kyrptonaught / Inventory-Sorter

Inventory Sorter for Fabric
MIT License
38 stars 36 forks source link

Game crashes on start in combination with Optifine #79

Open kamiMadara opened 1 year ago

kamiMadara commented 1 year ago

As stated, the game crashes on start in combination with Optifabric and therefore Optifine on Minecraft 1.19 The only thing resolving this issue was to remove the mod from the game.

AusSquatch commented 1 year ago

Having same issue as @kamiMadara . I love this mod. I would rather have it than not.

dsmilley commented 1 year ago

I have the same issue

kyrptonaught commented 1 year ago

Can anyone provide a log? I believe this is a conflict with my config library used in this mod.

If it's the same as my other mod, this has to do with a keybinding related mixin conflict. Why is optifine touching keybinds. Ugh

https://github.com/kyrptonaught/CMDKeybinds/issues/25

kamiMadara commented 1 year ago

This is my log @kyrptonaught as it seems the oshi.properties is at fault ... what ever this file does

[10:48:45] [main/INFO]: SpongePowered MIXIN Subsystem Version=0.8.5 Source=file:/C:/Users/user/AppData/Roaming/.minecraft/libraries/net/fabricmc/sponge-mixin/0.11.4+mixin.0.8.5/sponge-mixin-0.11.4+mixin.0.8.5.jar Service=Knot/Fabric Env=CLIENT
[10:48:45] [main/INFO]: Compatibility level set to JAVA_16
[10:48:45] [main/INFO]: Compatibility level set to JAVA_17
[10:48:48] [main/WARN]: Configuration conflict: there is more than one oshi.properties file on the classpath
[10:48:48] [main/WARN]: Configuration conflict: there is more than one oshi.architecture.properties file on the classpath
[10:48:50] [main/ERROR]: Minecraft has crashed!
net.fabricmc.loader.impl.FormattedException: java.lang.ExceptionInInitializerError
    at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:463) ~[fabric-loader-0.14.7.jar:?]
    at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) [fabric-loader-0.14.7.jar:?]
    at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.14.7.jar:?]
Caused by: java.lang.ExceptionInInitializerError
    at net.minecraft.class_128.method_568(class_128.java:173) ~[client-intermediary.jar:?]
    at net.minecraft.class_128.method_24305(class_128.java:343) ~[client-intermediary.jar:?]
    at net.minecraft.client.main.Main.main(Main.java:152) ~[fabric-loader-0.14.7-1.19.jar:?]
    at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461) ~[fabric-loader-0.14.7.jar:?]
    ... 2 more
Caused by: java.lang.RuntimeException: Mixin transformation of net.minecraft.class_315 failed
    at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:418) ~[fabric-loader-0.14.7.jar:?]
    at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:322) ~[fabric-loader-0.14.7.jar:?]
    at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218) ~[fabric-loader-0.14.7.jar:?]
    at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:145) ~[fabric-loader-0.14.7.jar:?]
    at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
    at java.lang.Class.getDeclaredFields0(Native Method) ~[?:?]
    at java.lang.Class.privateGetDeclaredFields(Class.java:3297) ~[?:?]
    at java.lang.Class.getDeclaredFields(Class.java:2371) ~[?:?]
    at net.optifine.reflect.FieldLocatorTypes.<init>(FieldLocatorTypes.java:25) ~[Optifine-mapped.jar:?]
    at net.optifine.reflect.Reflector.<clinit>(Reflector.java:499) ~[Optifine-mapped.jar:?]
    at net.minecraft.class_128.method_568(class_128.java:173) ~[client-intermediary.jar:?]
    at net.minecraft.class_128.method_24305(class_128.java:343) ~[client-intermediary.jar:?]
    at net.minecraft.client.main.Main.main(Main.java:152) ~[fabric-loader-0.14.7-1.19.jar:?]
    at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461) ~[fabric-loader-0.14.7.jar:?]
    ... 2 more
Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
    at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:392) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
    at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
    at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
    at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:413) ~[fabric-loader-0.14.7.jar:?]
    at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:322) ~[fabric-loader-0.14.7.jar:?]
    at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218) ~[fabric-loader-0.14.7.jar:?]
    at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:145) ~[fabric-loader-0.14.7.jar:?]
    at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
    at java.lang.Class.getDeclaredFields0(Native Method) ~[?:?]
    at java.lang.Class.privateGetDeclaredFields(Class.java:3297) ~[?:?]
    at java.lang.Class.getDeclaredFields(Class.java:2371) ~[?:?]
    at net.optifine.reflect.FieldLocatorTypes.<init>(FieldLocatorTypes.java:25) ~[Optifine-mapped.jar:?]
    at net.optifine.reflect.Reflector.<clinit>(Reflector.java:499) ~[Optifine-mapped.jar:?]
    at net.minecraft.class_128.method_568(class_128.java:173) ~[client-intermediary.jar:?]
    at net.minecraft.class_128.method_24305(class_128.java:343) ~[client-intermediary.jar:?]
    at net.minecraft.client.main.Main.main(Main.java:152) ~[fabric-loader-0.14.7-1.19.jar:?]
    at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461) ~[fabric-loader-0.14.7.jar:?]
    ... 2 more
Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Redirector spoofDisplayOnlyKeyBinds(Lnet/minecraft/class_304;)Ljava/lang/String; in net.kyrptonaught.kyrptconfig.json:displaykeybind.GameOptionsMixin from mod kyrptconfig failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap kyrptconfig-refmap.json
    at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.postInject(InjectionInfo.java:468) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
    at org.spongepowered.asm.mixin.transformer.MixinTargetContext.applyInjections(MixinTargetContext.java:1385) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
    at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyInjections(MixinApplicatorStandard.java:1052) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
    at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:400) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
    at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:325) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
    at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:421) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
    at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
    at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
    at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
    at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202) ~[sponge-mixin-0.11.4+mixin.0.8.5.jar:0.11.4+mixin.0.8.5]
    at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:413) ~[fabric-loader-0.14.7.jar:?]
    at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:322) ~[fabric-loader-0.14.7.jar:?]
    at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218) ~[fabric-loader-0.14.7.jar:?]
    at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:145) ~[fabric-loader-0.14.7.jar:?]
    at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
    at java.lang.Class.getDeclaredFields0(Native Method) ~[?:?]
    at java.lang.Class.privateGetDeclaredFields(Class.java:3297) ~[?:?]
    at java.lang.Class.getDeclaredFields(Class.java:2371) ~[?:?]
    at net.optifine.reflect.FieldLocatorTypes.<init>(FieldLocatorTypes.java:25) ~[Optifine-mapped.jar:?]
    at net.optifine.reflect.Reflector.<clinit>(Reflector.java:499) ~[Optifine-mapped.jar:?]
    at net.minecraft.class_128.method_568(class_128.java:173) ~[client-intermediary.jar:?]
    at net.minecraft.class_128.method_24305(class_128.java:343) ~[client-intermediary.jar:?]
    at net.minecraft.client.main.Main.main(Main.java:152) ~[fabric-loader-0.14.7-1.19.jar:?]
    at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461) ~[fabric-loader-0.14.7.jar:?]
    ... 2 more
kyrptonaught commented 1 year ago

The oshi.properties is a generic error that, I think thats always there.

The real cause is a mixin conflict. Optifine is doing stupid things(no surprise) messing up my mixins and causing a crash.

kyrptonaught commented 1 year ago

See more info here: https://github.com/kyrptonaught/CMDKeybinds/issues/25#issuecomment-1186792829

I have a prerelease available for testing. This may crash when used with my other mods InventorySorter-1.8.9-1.19 PRERELEASE.zip

kamiMadara commented 1 year ago

okey the prerelease does work, thanks for your effort :) If the prerelease comes with other issues I'll let you know as soon as I encounter them.

TrollCrab commented 1 year ago

Prerelease also working on our server. We will wait realease version too. Thanks for your work.

AusSquatch commented 1 year ago

Thanks Kyrptonaught. I'm checking out now. Clientside.

AusSquatch commented 1 year ago

So I have these mods installed and the Inventory Sorter isn't showing up in game at all. Am I missing any files ?

Picture

kyrptonaught commented 1 year ago

So I have these mods installed and the Inventory Sorter isn't showing up in game at all. Am I missing any files ?

Picture

Open up the zip, and grab the .jar out from inside.

AusSquatch commented 1 year ago

So I have these mods installed and the Inventory Sorter isn't showing up in game at all. Am I missing any files ? Picture

Open up the zip, and grab the .jar out from inside.

um... duh on my part...

Thank you kyrptonaught

kyrptonaught commented 1 year ago

I released 1.8.9 on curseforge