kyrptonaught / customportalapi

Developer Api for creating custom portals to any dimension
MIT License
63 stars 22 forks source link

Add Create Mod Trains Compatibility With Portals #101

Open TheRobbie73 opened 3 months ago

TheRobbie73 commented 3 months ago

Adds compatibility between Create trains and customportalapi

image

ezgif-2-2b4cbf544e

lexi-the-cute commented 1 month ago

nice! will have to see if i can get this to work on the 1.20.1 version

lexi-the-cute commented 1 month ago

well, the cherry picked code with changes loads and the nether side of things works, but am still dealing with the tracks not picking up the custom portals at all. this is in my attempt to get this pr into 1.20.1

edit: turns out that datapack portals is in fact not using the customportalapi jar built into its jar cause i just removed it and the portals themselves still work and light. so it wasnt even running my modified code when i swapped out the jars

edit 2: i think something in the pack is also adding customportalapi

lexi-the-cute commented 1 month ago

yes, another mod is adding its own copy of CustomPortalApi and i need to track it down. i did manage to successfully cherry pick this PR and get it working on 1.20.1 with the latest Create https://github.com/lexi-the-cute/customportalapi/commit/d8f877ac695df356c5801e3b1c113b91cb70316e

2024-07-11_08 35 02

lexi-the-cute commented 1 month ago

definitely feel like im being punked. it works in single player, but then has create throw the "portal not generated on other side" error message in multiplayer when i install it on the server