search

kyrptonaught / customportalapi

Developer Api for creating custom portals to any dimension
MIT License
64 stars 22 forks source link

Falt Portals dont seem to work #36

Closed frikinjay closed 3 years ago

frikinjay commented 3 years ago

I see in the latest commit that flat portals are possible now but using this i cant seem to activate the portal with a 5x5 obsidian portal with a flint and steel.

CustomPortalBuilder.beginPortal() .frameBlock(Blocks.OBSIDIAN) .destDimID(new Identifier("the_nether")) .tintColor(131,66,184) .flatPortal() .registerPortal();

image

kyrptonaught commented 3 years ago

Can you try a different block? You also probably have an error in the log about registering a portal that already exists.

When registering a portal it checks for conflicting portals, but doesn't check if they are of different types. It's most likely detecting this as a conflict

frikinjay commented 3 years ago

I see, I'll try it with a different block. It'd be nice if it detects different types of portals for the same block types.

frikinjay commented 3 years ago

It works with other blocks. Thanks for the help : ) But yeah the above thing would be nice as a feature if you're looking for enhancement suggestions.

kyrptonaught commented 3 years ago

I did it to help avoid confusion for the player. They may make a flat version of a portal and expect it to go to the same place. Not sure if it's really a big deal but that was my thinking

frikinjay commented 3 years ago

Ah fair, well i'll close it since its working as intended.