search

kyrptonaught / customportalapi

Developer Api for creating custom portals to any dimension
MIT License
63 stars 22 forks source link

Could not find maven.modrinth:sodium:mc1.19.4-0.4.10 #75

Open TheJoppeBijlsma opened 1 year ago

TheJoppeBijlsma commented 1 year ago

I get this error message when trying to place everything in the build.gradle file and refreshing grade

Scherm­afbeelding 2023-04-26 om 22 54 32
kyrptonaught commented 1 year ago

The newer releases bundle sodium in order to add compatibility.

You can either add the repo for sodium:

repositories {
    maven { url "https://api.modrinth.com/maven" }
}

or exclude sodium:

//customportalapi
modImplementation include('net.kyrptonaught:customportalapi:0.0.1-beta63-1.19.4') {
    exclude group: "net.fabricmc.fabric-api"
    exclude module: "sodium"
}
JoeyDP commented 1 year ago

Your solution indeed prevents sodium from being added to dependent mods. However, the Mixin you added is still being applied and fails if sodium is not present:

[main/WARN] (FabricLoader/Mixin) Error loading class: me/jellysquid/mods/sodium/client/model/quad/blender/LinearColorBlender (java.lang.ClassNotFoundException: me/jellysquid/mods/sodium/client/model/quad/blender/LinearColorBlender)

I would prefer if sodium is not bundled with custom portals api and if it can be added as an optional dependency. The following PR should update the configuration accordingly: #76.