search

kyrptonaught / tooltipfix

MIT License
25 stars 11 forks source link

Crashing When Modifying Configurations #1

Closed Mino-dev closed 4 years ago

Mino-dev commented 4 years ago

The game crashes when trying to access configs (any other mod) through Mod Menu with this mod installed. Here are the logs: Crash-report: https://paste.ee/p/ldasa Full-log: https://paste.ee/p/qoeSg

Hope this information will help you. Thanks for your time creating this wonderful mod!

Mhowser commented 4 years ago

I'm having the same problem https://pastebin.com/K0tfemzX

kyrptonaught commented 4 years ago

Thanks for the report, I'll take a look at this later today

kyrptonaught commented 4 years ago

1.0.1 should fix this

Mino-dev commented 4 years ago

Thank you for the quick fix! Will close the issue.

egeesin commented 3 years ago

Somehow same error occurs when using Mod Menu with Turkish language. As soon as I hover on configure button, game crashes without showing the "Ayarla..."(Configure...) tooltip unless I disable ToolTipFix. Here's my console output.

kyrptonaught commented 3 years ago

Does it crash on another language? Or just Turkish?

egeesin commented 3 years ago

I tried Polish too (which has one of the newest approved translations) but it showed the tooltip without a problem. I'm pretty sure that there's no syntax error in the tr_tr.json. Not my strongest guess but I have a suspicion that it may be something to do with the string length. I'll test different lengths and languages.

kyrptonaught commented 3 years ago

The error implies that it's due to an empty string, but there's a check above to prevent that from happening. Very odd

egeesin commented 3 years ago

Original string: "Configure..." (Total length is 12) Polish string: "Skonfiguruj..." (Total length is 14) Turkish string: "Ayarla..." (Total length is 9) Chinese (Simplified) string: "配置…" (Total length is 3) Italian string: "Configura" (Total length is 9) Russian string: "Настроить..." (Total length is 12) Brazillian Portuegese: "Configuração..." (Total length is 16)

Game crashed when language set to Turkish, Italian, Chinese (S) and I think when tooltip length is above 12 the game doesn't crash.

Tried to add more dots to "Ayarla...". Screen Shot 2020-11-15 at 2 54 52 PM Didn't crash with 5 dots (with 12 total char) Then tried with 12 dots and didn't crashed. Screen Shot 2020-11-15 at 3 02 15 PM Also tried "————————————" (11x —) to prove tooltip width is irrelevant, then it crashed.

It should be the minimum string length and the position of the configure button. (very close to top-right edge.)

kyrptonaught commented 3 years ago

Ah can you update tooltipfix tp 1.0.2. I thought for sure I already fixed this, and just saw in your log that you're using an old version. Thank you for the very in depth testing and investigation though!

egeesin commented 3 years ago

Ahh, my bad. Must have missed that one! I thought it was up to date, got worried there. There's no problem with 1.0.2 now, thanks!