kyrptonaught / tooltipfix

MIT License
25 stars 10 forks source link

TooltipFix breaks vanilla and modded TooltipPositioners, breaks EMI #30

Open emilyploszaj opened 1 year ago

emilyploszaj commented 1 year ago

In 1.19.3 Mojang added the ability for tooltips to use TooltipPositioners that dictate their place on the screen and handle things such as wrapping. TooltipFix completely ignores them and then breaks them by changing the x position of any tooltip. For instance, a mod like EMI that wants to have certain tooltips always render flipped to the left will simply be broken, its tooltips will be wrapped and not be moved. Instead of injecting into the raw render methods, in 1.19.3+, TooltipFix should be modifying the HoveredTooltipPositioner class which handles the vanilla logic for positioning and flipping tooltips, or otherwise doing nothing when non-vanilla tooltip positioners are used.

Example in EMI in vanilla: image

Then EMI with TooltipFix: image

peow commented 4 months ago

any update here? this is causing trouble while using EMI + Legendary Tooltips image