search

kyrylo / pry-theme

An easy way to customize Pry colors via theme files
zlib License
171 stars 14 forks source link

Leaky colors #26

Closed rking closed 11 years ago

rking commented 11 years ago

If I go to repo pry, and add gem 'pry-theme' to the Gemfile, then bundle exec rake pry, then look at _pry_, string boundaries are wrong and stuff.

It looks like this: http://showterm.io/14f8d7efcb622026eda9d

Do you know why?

kyrylo commented 11 years ago

What is your theme?

rking commented 11 years ago

The first was vim-detailed, but it does it to a lesser degree with default: http://showterm.io/f5dea40c15c11b4818faa

But I looked closer at the version without pry-theme is actually wrong in some way: http://showterm.io/aa8ea9cb8a3d93c283961 (Notice the first few attributes are not colored right.)

kyrylo commented 11 years ago

Could you try Pry Theme from HEAD? If the problem persists, then it's a CodeRay bug. Pry Theme doesn't parse anything.

rking commented 11 years ago

master branch pry-theme isn't working so great for me.

I didn't uninstall the previous pry-theme first, but when I did a 'gem install' from the working dir I got a non-working vim-detailed (possibly because vim-detailed.rb and vim-default.rb both now say #coding: utf-8 rather than # encoding: utf-8 ?).

But then when I fixed that, there are still a bunch of ~/.pry/themes/*.prytheme that are getting sourced. I think you need to write some migration code to delete those, or else glob on *.rb.

Maybe also only load the files if the users ask for them (via setting them as their preferred theme, or listing all themes).

Thanks for your work, as always!

kyrylo commented 11 years ago

#coding: utf-8 is a typo. But anyway, aren't # coding: utf-8 and # encoding: utf-8 synonyms?

So, if you change # coding: utf-8 to # encoding: utf-8, then vim-detailed has no colour leaks?

But then when I fixed that, there are still a bunch of ~/.pry/themes/.prytheme that are getting sourced. I think you need to write some migration code to delete those, or else glob on .rb.

This is an idea. Thank you.

Maybe also only load the files if the users ask for them (via setting them as their preferred theme, or listing all themes).

I disagree. What's wrong with the current approach? It requires no messing with .pryrc: you get everything right away. It wouldn't even reduce the loading time (notedly).

Thanks for participating.

kyrylo commented 11 years ago

By the way, I forgot to mention that you should use pry from HEAD, too. :-D

kyrylo commented 11 years ago

I don't think it's Pry Theme's fault.