search

kyrylo / pry-theme

An easy way to customize Pry colors via theme files
zlib License
171 stars 14 forks source link

Delete never used cli.rb #47

Closed neves closed 8 years ago

neves commented 9 years ago

cli.rb is loaded by pry at startup, looking for cli options to add to pry command options. This file is slowing pry startup by 50%, but it's never used. It's ok to not exist, since pry checks it: https://github.com/pry/pry/blob/master/lib/pry/plugins.rb#L38

The same was proposed to pry-byebug: deivid-rodriguez/pry-byebug#76 and pry-rescue: https://github.com/ConradIrwin/pry-rescue/pull/91

kyrylo commented 9 years ago
  1. For some reason this breaks the test suite.
  2. It was added to integrate with pry-rescue better. See the description: https://github.com/kyrylo/pry-theme/commit/b4a20d4aed76154a94d0d39882285eb8bb0859fd

We can safely remove the file, if pry-rescue removes it as well.