Open Sleepful opened 4 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
kysely | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 18, 2024 10:58pm |
I can't see the details of the CI failing 😅
@igalklebanov hello 👋 do you think this documentation is helpful?
I can't see the details of the CI failing 😅
Did you run your changes locally?
Oh yeah, I was using npm start
and it didn't error.
Now that I see your screenshot, I see that I should have been running npm run build
to check.
I updated the PR:
/site/README.md
where I mention that npm run build
checks for correctness. master
to reconcile the changes from your recent PR: https://github.com/kysely-org/kysely/pull/1035/filesI can continue updating with master branch, but first I will wait to get approval or feedback on the changes
Hello!
It took me a while to figure out this one, here I hope to make it easier to others.