kysely-org / kysely

A type-safe typescript SQL query builder
https://kysely.dev
MIT License
9.81k stars 249 forks source link

"Extending kysely" example doesn't compile #1052

Closed Andrey36652 closed 1 week ago

Andrey36652 commented 1 week ago

Example https://kysely.dev/docs/recipes/extending-kysely#a-more-complex-example does not compile with error

src/db/kysely-helpers.ts:30:5 - error TS2322: Type 'AliasedRawBuilder<unknown, A>' is not assignable to type 'AliasedRawBuilder<R, A>'.
  Type 'unknown' is not assignable to type 'R'.
    'R' could be instantiated with an arbitrary type which could be unrelated to 'unknown'.

30     return sql`(values ${values})`.as<A>(aliasSql)

kysely 0.27.3 typescript 5.4.4 ts-node 10.9.2

This error can be fixed by replacing string return sql`(values ${values})`.as<A>(aliasSql) with return sql`(values ${values})`.as<A>(aliasSql) as as AliasedRawBuilder<R, A>

igalklebanov commented 1 week ago

Hey 👋

This is resolved with sql<R> instead of sql.

Andrey36652 commented 1 week ago

@igalklebanov can docs be fixed?

igalklebanov commented 1 week ago

Yeah, should be resolved now.