Add support for extracting original array type for ColumnType array

kysely-org / kysely

A type-safe typescript SQL query builder

https://kysely.dev

MIT License

9.9k stars 249 forks source link

Add support for extracting original array type for ColumnType array #958

Closed pavestru closed 2 months ago

pavestru commented 2 months ago

Fixes #957

SelectType<T>, InsertType<T> and UpdateType<T> definitions were extended to allow for extraction of the underlying type for ColumnType array.
Typings tests were added for all of the above (i.e. select, insert, update).

For more information about the rationale, read description of #957 .

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
kysely	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 22, 2024 9:07pm

igalklebanov commented 2 months ago

Hey 👋

This could be fine on the premise that ColumnType<...>[] is a thing. This is wrong usage of ColumnType - it should always be singular - the types passed to it can be arrays.