4.0 can't receive DisplayImage

[GoogleCodeExporter]

What steps will reproduce the problem?
1. login with MSNPSharp 4.0 example client
2. open a conversation dialog

What is the expected output? What do you see instead?
After a short waiting, remote user's icon should be fetched. But now nothing 
was shown.

Please use labels and text to provide additional information.

It seem's that 4.0's p2p stack version check function has problem, the remote 
client is using P2P v2, but MSNPSharp thought it using v1. This is the trace 
log:

SBBridge: P2PBridge 2:SBBridge opened
SBMessageProcessor: Outgoing message:
MSG 5 D 889

MIME-Version: 1.0
P2P-Dest: freezingsoft@hotmail.com
P2P-Src: testmsnpsharp@hotmail.com
Content-Type: application/x-msnmsgrp2p

[P2PMessage]
[P2Pv1Header]
SessionId     : 0 (0)
Identifier    : 2911e784 (689039236)
Offset        : 0 (0)
TotalSize     : 2c0 (704)
MessageSize   : 2c0 (704)
Flags         : MSNSLPInfo (16777216)
AckSessionId  : 2576c932 (628541746)
AckIdentifier : 0 (0)
AckTotalSize  : 0 (0)
FOOTER              : 0 (0)
DATA                : INVITE MSNMSGR:freezingsoft@hotmail.com MSNSLP/1.0
Call-ID: {1B670775-35C4-4895-A408-701FFC7587F4}
Content-Length: 352
Content-Type: application/x-msnmsgr-sessionreqbody
CSeq: 0
From: <msnmsgr:testmsnpsharp@hotmail.com>
Max-Forwards: 0
To: <msnmsgr:freezingsoft@hotmail.com>
Via: MSNSLP/1.0/TLP;branch={279DBC99-561D-4068-8945-59EF67B54A44}

AppID: 12
Context: 
PG1zbm9iaiBDcmVhdG9yPSJmcmVlemluZ3NvZnRAaG90bWFpbC5jb20iIFNpemU9IjQ4MzciIFR5cGU9
IjMiIExvY2F0aW9uPSJURlIyQzIudG1wIiBGcmllbmRseT0iQUFBPSIgU0hBMUQ9IitIYzBRZFJyWWMy
QjZYS1JDbmhQQlRqNGRQND0iIFNIQTFDPSJ1c0draWkrb2tYd1NmL3V2SFNXWG5xSXlia2c9Ii8+
EUF-GUID: {A4268EEC-FEC5-49E5-95C3-F126696BDBF6}
RequestFlags: 18
SessionID: 1318686061

Original issue reported on code.google.com by freezing...@gmail.com on 28 Nov 2010 at 9:34

[GoogleCodeExporter]

Now it can work, but sometimes I got a TURN error then the library didn't try 
to get the icon from SB. In that case I had to end the application and login 
again, then it works.

Original comment by freezing...@gmail.com on 29 Nov 2010 at 2:13

[GoogleCodeExporter]

Not work again. You nee dto have a regression test once after you thought 
you've finished fixing a bug.

Original comment by freezing...@gmail.com on 10 Dec 2010 at 3:05

Attachments:

• dispimage_not_work.TXT

[GoogleCodeExporter]

First of all, this issue is stil open, not fixed. Then this is DEV branch and 
all P2P code are new, and bugs are expected.

I found that the problem is about rak reply's Identifier:
Identifier must be: 7b869090 (2072416400)

[P2PMessage]
[P2Pv2Header]
HeaderLength        : 10 (16)
OperationCode       : 0 (0)
MessageSize         : 0 (0)
Identifier          : 10c0a80e (281061390)
AckIdentifier       : cdecdb24 (3454851876)
NakIdentifier       : 0 (0)
Header TLVs  (1)    : 2(2),4(4),( 0xcd 0xec 0xdb 0x24 ); 
 Data HeaderLength  : 0 (0)
 TFCombination      : None (0)
 PackageNumber      : 0 (0)
 SessionId          : 0 (0)
 DataRemaining      : 0 (0)
 DataPacket TLVs (0): 
FOOTER              : 0 (0)
DATA                : Binary data: 0 bytes

If raks are session independed session.LocalIdentifier must be ignored. But 
when ignored NAKs are received again.

I think we must move all (P2PSession) LocalId, RemoteId to P2PBridge. These 
sequence numbers must be given by P2PBridge if we want to not receive NAK.

What is your opinion?

Original comment by hepha...@gmail.com on 12 Dec 2010 at 7:40

• Added labels: Milestone-Release4.0.0

[GoogleCodeExporter]

ok, just have a try :)

Original comment by freezing...@gmail.com on 12 Dec 2010 at 1:23

[GoogleCodeExporter]

The same thing for the 3.1 stable. Your display picture corrupted. First 4 
bytes are for corrupted images are: 0x05, 0x40, 0x00, 0x80

Original wlm client can't get your image, too.

It works for other contacts.

Original comment by hepha...@gmail.com on 13 Dec 2010 at 2:45

• Changed state: Invalid

[GoogleCodeExporter]

You are right. Actually this is a bug of wlm2011: If you logged in with the 
desktop client and the web client (I mean , hotmail web messenger), you will 
lost your display image.

Original comment by freezing...@gmail.com on 13 Dec 2010 at 5:22