ReverseAdded event not fired (Offline Mode)

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Logon to MSNPSharp client with account A, and another client with account B
2. add account A to account B's contact list
3. Wait for invitation to arrive.

What is the expected output? What do you see instead?
after step 2, I'd expect that the Example client would open the ReverseAdded 
form, but in reality, a ReverseAdded event is not fired at all (I checked to 
make sure).

In this paste of the tracelog, you see on line 369 that the invitation has been 
received, but for some reason the event is not fired.
http://pastebin.com/FHEs90rY

On a side-note: If this is to be expected, am I wrong in assuming that the 
invitation *should* be processed on next login? (It isn't).

What version of the product are you using? (MSNPSharp, OS, Mono etc.)
MSNPSharp 310 Release

Is your code check out from SVN or download from our download site?
Download from your download site.

Please provide any additional information below:

Original issue reported on code.google.com by CainJ...@gmail.com on 20 Jan 2011 at 1:18

[GoogleCodeExporter]

Sorry, I'm using Windows 7, and the latest version of .net that I have 
installed is 4.0.30319.1

Original comment by CainJ...@gmail.com on 20 Jan 2011 at 1:33

[GoogleCodeExporter]

My apologies. I should have tried the latest dev version. It appears to be 
working fine in the development version (v4.0.0 r1824)

Original comment by CainJ...@gmail.com on 20 Jan 2011 at 3:36

[GoogleCodeExporter]

No need to apologies, it should work for the stable version, let me check it 
out.

Original comment by freezing...@gmail.com on 20 Jan 2011 at 5:24

[GoogleCodeExporter]

Two things:
1. Are you sure the DEV version can work? I believe not because the code for 
that part is actually the same. Please use a contact that never added to your 
contact list before to try again.
2. If it does not work, please check out branches/MSNPSHARP_31_STABLE and try 
again. I checked in a patch but don't know whether it works or not.

Original comment by freezing...@gmail.com on 20 Jan 2011 at 7:14

[GoogleCodeExporter]

Original comment by freezing...@gmail.com on 20 Jan 2011 at 7:14

[GoogleCodeExporter]

Hmm, Maybe I was just lucky after I updated to the SVN version.

@ #1, I have now tested it 4 times with 3 unique accounts adding the account 
logged into MSNPSharp test client (dev version).

The ReverseAdded Event did *not* fire the first time, the second and third time 
the ReverseAdded Event fired just fine. I then proceeded to readd the 
MSNP-account using the first account I used the first time (I restarted the 
client before I did this), the ReverseAdded event fired just fine.

Is there anything that I could have done wrong the first time? Or is it just 
unlucky that the event did not fire? Having only glanced at your code (and 
being very new at C#), could it be possible that the ContactList hasn't been 
updated by the time line #2834 is being executed? It just seems very odd that 
it fails occasionally.

I will checkout the stable branch now and test it out regardless.

Original comment by CainJ...@gmail.com on 20 Jan 2011 at 8:49

[GoogleCodeExporter]

This issue was closed by revision r1928.

Original comment by hepha...@gmail.com on 20 Jan 2011 at 11:13

• Changed state: Fixed

[GoogleCodeExporter]

This issue was updated by revision r1929.

Don't remove pending contact if added remotely.

Labels: +Milestone-Release4.0.0, +Milestone-Release3.1.1

Original comment by hepha...@gmail.com on 20 Jan 2011 at 1:14

[GoogleCodeExporter]

This issue was updated by revision r1930.

Labels: +Milestone-Release4.0.0 +Milestone-Release3.1.1

Original comment by hepha...@gmail.com on 20 Jan 2011 at 1:26

[GoogleCodeExporter]

This issue was updated by revision r1931.

Labels: +Milestone-Release4.0.0
Labels: +Milestone-Release3.1.1

Original comment by hepha...@gmail.com on 20 Jan 2011 at 1:28

[GoogleCodeExporter]

This issue was updated by revision r1932.

Label test

http://code.google.com/p/support/wiki/IssueTracker#Integration_with_version_cont
rol

Original comment by hepha...@gmail.com on 20 Jan 2011 at 1:40

• Added labels: Milestone-Release4.0.0, Milestone-Release3.1.1

[GoogleCodeExporter]

please don't use the issue tracker unless important issue (sure, this is an 
important one), it will just spam our changing list and email.

Original comment by freezing...@gmail.com on 20 Jan 2011 at 9:36

[GoogleCodeExporter]

My apologies. Next time i'll check and recheck a lot before submitting to the 
bug tracker.

Original comment by CainJ...@gmail.com on 20 Jan 2011 at 10:08

[GoogleCodeExporter]

No man, don't worry about that, I am talking to my teammate :)

Original comment by freezing...@gmail.com on 20 Jan 2011 at 10:26

[GoogleCodeExporter]

:)

Cain,
This bug important, off course you will report bugs and we will fix them.
Pang talking about (it will just spam our changing list and email.)
Because I added him to CC, this is not about you.

I have fixed this issue yesterday and I will release a new version today. 
Because it is high priority. The library wasn't fire ReverseAdded event and 
will remove pending contact from Nameserver.ContactList. But it keeps in MCL 
file. Why delete?
Look here:

XMLContactList.cs:2450
- if (needsDelete)
+ if (needsDelete && contact.Lists == MSNLists.None)
  contactList.Remove(account, type);

How to reproduce?
1- Logoff from MSNPSharp client with account A
2- Login with WLM with account B and add A and logoff
3- Logon to MSNPSharp client with account A
4- The ReverseAdded will never fired, because it is deleted by 
contactList.Remove.

Anyway, thank you very much for the bug report again. And we are need you to 
find bugs.

Original comment by hepha...@gmail.com on 21 Jan 2011 at 9:09

• Changed title: ReverseAdded event not fired (Offline Mode)
• Added labels: Priority-High
• Removed labels: Priority-Medium, Milestone-Release4.0.0

[GoogleCodeExporter]

It's really a weird bug :)

Original comment by freezing...@gmail.com on 21 Jan 2011 at 5:51