Malformed name of contacts in multiparty chat

[GoogleCodeExporter]

What steps will reproduce the problem?
1. You'll need 3 accounts. Each account should have the other accounts in the 
it's contact list.
2. Use MSNPSharp 4 test client and 2 other MSNP compatible clients
3. Sign in with each account with a different client.
4. Start a conversation to the second contact using the test client.
5. Invite the third contact.

What is the expected output? What do you see instead?
When someone else (except you) in the multiparty chat session, sends a message, 
it's name is malformed. You'll see something like bea-caaac-xxxccc-0000@live.com

What version of the product are you using? (MSNPSharp, OS, Mono etc.)
MSNPSharp 4.0.1, NET 2.0, Windows x64

Is your code check out from SVN or download from our download site?
Download site

Original issue reported on code.google.com by kernel...@gmail.com on 5 Jul 2011 at 10:14

[GoogleCodeExporter]

Original comment by freezing...@gmail.com on 7 Jul 2011 at 8:36

[GoogleCodeExporter]

Actually it isn't malformed. You must use e.OriginalSender instead.

e.Sender is sometimes circle, multiparty, shell or invidual contact. You must 
answer to this contact if you want to continue chat...

e.OriginalSender is the real contact.. 1 ON 1 CHAT.

private void PrintTyping(TypingArrivedEventArgs e)

        {

            DisplaySystemMessage(e.Sender.Account + " is typing... invidual sender=" + e.OriginalSender);

        }

Original comment by hepha...@gmail.com on 8 Jul 2011 at 12:59

• Changed state: Invalid

[GoogleCodeExporter]

Ethem,
Can you make the OriginalSender to Sender and create a property called 
GatewayContact? The name here is misleading.

Original comment by freezing...@gmail.com on 8 Jul 2011 at 8:11

[GoogleCodeExporter]

Sorry,

I think you don't understand the idea behind Sender. Who cares gateway contact?

READ THIS AGAIN:

e.Sender is sometimes circle, multiparty, shell or invidual contact. You must 
answer to this contact if you want to CONTINUE CHAT... (FOR BACKWARD 
COMPABILITY)

e.OriginalSender is the real contact.. 1 ON 1 CHAT. THIS IS ALWAYS INVIDUAL 
CONTACT.

Original comment by hepha...@gmail.com on 10 Jul 2011 at 12:00

[GoogleCodeExporter]

literally speaking, sender means person who sends the message, but now the 
sender is actually a gateway, that's why I say it's misleading.

Original comment by freezing...@gmail.com on 11 Jul 2011 at 5:32

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Ok then, I will redesign properties. The new design is:

e.Sender: [Obsolete] || (e.Gateway == null ? e.From : e.Gateway)
e.OriginalSender: [Obsolete]

e.From: MimeMessage.From, before ";via"
e.Gateway: MimeMessage.From: header after ";via" or MimeMessage.Via

If you accept this or have an idea, share it.

One more thing:

From is sometimes cirle or multipary. Will we use this as Gateway or From???

PUT 35 OK 165
Routing: 1.0
To: 1:testmsnpsharp@live.cn;epid={ad9d9247-9181-4c57-8388-248304e153d3}
From: 10:588e793a-003d-0003-4136-314b00000000@live.com

Original comment by hepha...@gmail.com on 11 Jul 2011 at 7:55

[GoogleCodeExporter]

ah..if the From sometimes is the circle.. let's don't change anything, it just 
make it more complicated.. just retain this design then..

Original comment by freezing...@gmail.com on 11 Jul 2011 at 9:48