kytos-ng / kytos-end-to-end-tests

Kytos End-to-End Tests
0 stars 10 forks source link

[Fix] MW flaky test case #148

Closed viniarck closed 2 years ago

viniarck commented 2 years ago

Fixes #145

This PR is on topf of PR #147

The test case looks good, I've explored it, looks like it's a convergence issue, where a flow hasn't been deleted yet in the switch, no false positives or consistency check reinstalling them though. I've slightly increase the sleep to have an extra time before checking the flows, that should suffice, I believe, I've run 5 iterations locally:

root@be0714fb5efc:/# cat script.sh
#!/bin/bash

for i in {1..5}
do
   echo "Running iteration $i..."
   python3 -m pytest tests/ --timeout=360 -k test_010_create_mw_on_switch_should_move_evc
   sleep 10
done
root@be0714fb5efc:/# grep -i "consistency" /var/log/messages

============================================================== 1 passed, 198 deselected, 34 warnings in 226.82s (0:03:46) ===============================================================
Running iteration 5...
================================================================================== test session starts ==================================================================================
platform linux -- Python 3.9.2, pytest-6.2.5, py-1.11.0, pluggy-1.0.0
rootdir: /tests
plugins: timeout-2.0.2
timeout: 360.0s
timeout method: signal
timeout func_only: False
collected 199 items / 198 deselected / 1 selected

tests/test_e2e_15_maintenance.py .                                                                                                                                                [100%]

============================================================== 1 passed, 198 deselected, 34 warnings in 237.06s (0:03:57) ===============================================================
root@be0714fb5efc:/# cat script.sh
viniarck commented 2 years ago

Thanks for reviewing, Italo.