Closed viniarck closed 11 months ago
LGTM but it seems unnecessary. For a napp to be included in the
required_napps
set, it must be in the pipeline being enabled, insideSUBSCRIBED_NAPPS
and installed. Currently, I have not foundtelemetry_int
being installed in the dock image.
Indeed @Alopalao. Good point.
I was also hoping that it'd be one step towards also eventually supporting telemetry_int
, when we also start using the noviflow backend, but then when we also were to build telemetry_int
on the docker image other unit tests like test_e2e_01_kytos_startup.py
would need to be augmented, and also of_multi_table
settings.SUBSCRIBED_NAPPS would probably need to be set via an env var. So, I'll go ahead and close this PR and once we start supporting telemetry_int
on e2e tests then issue https://github.com/kytos-ng/kytos-end-to-end-tests/issues/263 will get revisited. For completeness, I've also rerun e2e with the test suite test_e2e_60_of_multi_table
without this branch here and it's passing as expected:
============================= test session starts ==============================
platform linux -- Python 3.9.2, pytest-7.2.0, pluggy-1.3.0
rootdir: /builds/amlight/kytos-end-to-end-tester/kytos-end-to-end-tests
plugins: rerunfailures-10.2, timeout-2.1.0, anyio-3.6.2
collected 242 items / 237 deselected / 5 selected
tests/test_e2e_60_of_multi_table.py ..... [100%]
------------------------------- start/stop times -------------------------------
========== 5 passed, 237 deselected, 35 warnings in 290.48s (0:04:50) ==========
Closes #263
Summary
End-to-End Tests
Test suite
test_e2e_60_of_multi_table
is passing with this branch and PR https://github.com/kytos-ng/of_multi_table/pull/21