search

kytos-ng / kytos-end-to-end-tests

Kytos End-to-End Tests
0 stars 10 forks source link

Pathfinder e2e Test #265

Closed HeriLFIU closed 8 months ago

HeriLFIU commented 9 months ago

Closes #202

Summary

Added tests for pathfinder

End-to-End Tests

============================= test session starts ==============================
platform linux -- Python 3.9.2, pytest-7.2.0, pluggy-1.3.0
rootdir: /tests
plugins: rerunfailures-10.2, timeout-2.1.0, anyio-3.6.2
timeout: 60.0s
timeout method: signal
timeout func_only: False
collected 8 items

Test Results

image
HeriLFIU commented 9 months ago

tests/test_e2e_80_pathfinder.py

HeriLFIU commented 8 months ago

@HeriLFIU, congrats on your first contribution. It's great how you managed to group certain parameters and using that with pytest.mark.parametrize. It's a great start. I've asked a few minor changes though. Also, when posting the e2e exec if you could also post the result of the tests that'd be great, you've only posted the tests being collected.

In addition, since this is your first contribution, I'll need you to digitally sign Kytos-ng CLA

Sorry for the delay, I accidentally deleted the VirtualBox VM and when I had finished setting everything up again VirtualBox was giving me some strange errors.

I signed the Kytos-ng CLA

I successfully asserted:

  1. The exact paths that would be taken
  2. Their length
  3. Any other attributes

I used black to properly format the code.

I reduced the size of the long comment.

Lastly, I also added appropriate variable names.

I did one last review so I don't think I missed something, but If so I guess it will be mentioned in this next review.

HeriLFIU commented 8 months ago

I also added the test results as an image to the main description of the pull request.