search

kytos-ng / kytos

Kytos SDN Platform. Kytos is designed to be easy to install, use, develop and share Network Apps (NApps).
https://kytos-ng.github.io/
MIT License
3 stars 8 forks source link

`lockfile==0.12.2` is deprecated #156

Open viniarck opened 2 years ago

viniarck commented 2 years ago

lockfile was initially used in the codebase to lock kytosd.pid file it's now deprecated:

Note: This package is deprecated. It is highly preferred that instead of using this code base that instead fasteners or oslo.concurrency is used instead. For any questions or comments or further help needed please email openstack-dev and prefix your email subject with [oslo][pylockfile] (for a faster response).

Looking into the git history ee71ea01 fb167d3e02a8be5dec952f1ff49f00746ac9246f, it's not used anymore and the team started to use a file and if it exists as a lock

viniarck commented 2 years ago

we won't be able to remove since it's a dependency from python-daemon that we also have, python-daemon includes lockfile here upstream https://pagure.io/python-daemon/blob/main/f/setup.py#L71, we should keep an eye on this, if python-daemon moves forward we can update, otherwise if this becomes an issue in the future we should reassess python-daemon if it becomes a problem.