search

kytos-ng / kytos

Kytos SDN Platform. Kytos is designed to be easy to install, use, develop and share Network Apps (NApps).
https://kytos-ng.github.io/
MIT License
3 stars 7 forks source link

chore (docker development): moved Elasticsearch docker services to docker-compose.es.yml #382

Closed viniarck closed 1 year ago

viniarck commented 1 year ago

Closes #381

Summary

Moved Elasticsearch docker services to docker-compose.es.yml, only MongoDB related services will be spawn up by default, this also facilitates for developers who aren't using ES-related services, consuming less resources by default on development.

Local Tests

❯ docker-compose -f docker-compose.yml -f docker-compose.es.yml up -d
[+] Running 9/9
 ✔ Network kytos_default    Created                                                                                                                                                  0.0s 
 ✔ Container elasticsearch  Started                                                                                                                                                  0.8s 
 ✔ Container mongo2         Started                                                                                                                                                  0.8s 
 ✔ Container mongo3         Started                                                                                                                                                  0.8s 
 ✔ Container kibana         Started                                                                                                                                                  1.3s 
 ✔ Container mongo1         Started                                                                                                                                                  1.5s 
 ✔ Container filebeat       Started                                                                                                                                                  1.5s 
 ✔ Container mongo-rs-init  Started                                                                                                                                                  1.9s 
 ✔ Container apm            Started                                                                                                                                                  1.9s 

~/repos/kytos/ master* 
❯ docker-compose -f docker-compose.yml -f docker-compose.es.yml down
[+] Running 6/8
[+] Running 9/9m            Removed                                                                                                                                                  0.5s 
 ✔ Container apm            Removed                                                                                                                                                  0.5s 
 ✔ Container filebeat       Removed                                                                                                                                                  0.4s 
 ✔ Container mongo-rs-init  Removed                                                                                                                                                  3.5s 
 ✔ Container kibana         Removed                                                                                                                                                  0.3s 
 ✔ Container elasticsearch  Removed                                                                                                                                                  0.9s 
 ✔ Container mongo1         Removed                                                                                                                                                 10.3s 
 ✔ Container mongo2         Removed                                                                                                                                                 10.5s 
 ✔ Container mongo3         Removed                                                                                                                                                 10.5s 
 ✔ Network kytos_default    Removed                                                                                                                                                  0.1s 

~/repos/kytos/ master*  24s
❯ docker-compose up -d
[+] Running 5/5
 ✔ Network kytos_default    Created                                                                                                                                                  0.0s 
 ✔ Container mongo3         Started                                                                                                                                                  0.5s 
 ✔ Container mongo2         Started                                                                                                                                                  0.5s 
 ✔ Container mongo1         Started                                                                                                                                                  0.8s 
 ✔ Container mongo-rs-init  Started                                                                                                                                                  1.0s 

~/repos/kytos/ master* 
❯ docker-compose down
[+] Running 5/5
 ✔ Container mongo-rs-init  Removed                                                                                                                                                 10.3s 
 ✔ Container mongo1         Removed                                                                                                                                                 10.3s 
 ✔ Container mongo3         Removed                                                                                                                                                 10.6s 
 ✔ Container mongo2         Removed                                                                                                                                                 10.5s 
 ✔ Network kytos_default    Removed                                                                                                                                                  0.1s

End-to-End Tests

N/A

viniarck commented 1 year ago

LGTM. Simple and very useful change, @viniarck. I've found myself having to create a slim local compose file to set up the MongoDB services many times. This new proposal will be very helpful.

Appreciated your review, Italo. This will get merged soon.