search

kytos-ng / maintenance

Kytos Maintenance Window NApp
https://kytos-ng.github.io/api/maintenance.html
0 stars 7 forks source link

Fixed ui not using proper key for links #70

Closed Ktmi closed 1 year ago

Ktmi commented 1 year ago

Closes #69

Summary

Fixes the main UI component so that the proper key is used when setting links.

Local Tests

Embarrassingly enough, I have yet to actually set up a topology with links, which explains why this was missed before. I still have trouble setting up links, so I haven't been able to properly test this.

Ktmi commented 1 year ago

Looks good to me. Thanks for this patch, @Ktmi.

Could you also update the changelog? Also are we going to ship this as a patch 2022.3.1?

If you also need a quick way to have a topology on mininet with links you can you a linear topo for instance (or alternatively get a more complete topology from e2e helpers topologies):

❯ sudo mn --controller=remote,ip=127.0.0.1,port=6653 --switch=ovsk,protocols=OpenFlow13 --topo=linear,3

I was able to figure it out. I was already using mininet for the topologies, but I didn't realize I needed to enable each switch and interface.

italovalcy commented 1 year ago

Hi @viniarck,

Looks good to me. Thanks for this patch, @Ktmi.

Could you also update the changelog? Also are we going to ship this as a patch 2022.3.1?

IMHO we should ship this into 2022.3 (i.e., 2022.3.1)

viniarck commented 1 year ago

Hi @viniarck,

Looks good to me. Thanks for this patch, @Ktmi. Could you also update the changelog? Also are we going to ship this as a patch 2022.3.1?

IMHO we should ship this into 2022.3 (i.e., 2022.3.1)

Right. Sounds good. @Ktmi we have info about how to release a NApp on this page, feel free to proceed updating kytos.json in this same PR. If you need help let me know.

viniarck commented 1 year ago

Looks good to me. Thanks for this patch, @Ktmi. Could you also update the changelog? Also are we going to ship this as a patch 2022.3.1? If you also need a quick way to have a topology on mininet with links you can you a linear topo for instance (or alternatively get a more complete topology from e2e helpers topologies):

❯ sudo mn --controller=remote,ip=127.0.0.1,port=6653 --switch=ovsk,protocols=OpenFlow13 --topo=linear,3

I was able to figure it out. I was already using mininet for the topologies, but I didn't realize I needed to enable each switch and interface.

Great.

FYI, kytosd has a CLI option -E to enable all entities by default. That facilitates a lot to avoid having to enable the entities especially when developers are running it.