search

kytos-ng / maintenance

Kytos Maintenance Window NApp
https://kytos-ng.github.io/api/maintenance.html
0 stars 7 forks source link

Maintenance Modal Utilizes New Modal Component #92

Open HeriLFIU opened 1 week ago

HeriLFIU commented 1 week ago

Closes #N/A

Summary

A new modal component was added to the UI repository. This pull request makes it so that the maintenance UI now utilizes the new modal component.

Local Tests

A maintenance window was created and it was deleted utilizing the modal.

Associated Pull Requests

Parent

Description - UI repo in which the new modal component was implemented

Additional Issues

Buttons were utilizing :on_click="" which did not seem to function, so they were replaced with @click="".

HeriLFIU commented 1 week ago

I checked the rest of the UI for maintenance and they did already have :on_click="" replaced with @click="".

viniarck commented 1 week ago

Heriberto, now that your patch PR has landed https://github.com/kytos-ng/maintenance/pull/94, try rebasing with master and force push here, that should make the git history and you'd expect with the original changes that you meant to have here.

HeriLFIU commented 1 week ago

Yep, now the commit history looks good. Thanks.