search

kytos-ng / maintenance

Kytos Maintenance Window NApp
https://kytos-ng.github.io/api/maintenance.html
0 stars 8 forks source link

UI Button Fix #94

Closed HeriLFIU closed 2 months ago

HeriLFIU commented 2 months ago

Closes #93

Summary

Some buttons were using the old on_clickinstead of the new @click. These buttons were updated accordingly to use the new @click.

Local Tests

The buttons were pressed and they functioned as should.

HeriLFIU commented 2 months ago

@viniarck Everything should be working fine now. To avoid merge conflicts I performed a git interactive rebase and moved the commits relating to the button fixes to the start of my branch. I then force pushed the changes to main and created a new branch with these new changes. I then hard reset the new branch so that it only included the button commits, and since the two PR's now have the same base there should be no merge conflicts. At least in theory.

HeriLFIU commented 2 months ago

@viniarck I tested the modal, I am still able to delete maintenance windows and the buttons now function well. So I would say that nothing remains to be locally tested and we can ship it.

HeriLFIU commented 2 months ago

@viniarck Maybe for the future we can update the start and end date sections for maintenance so that users don't have to type in a date in such a format and in UTC. image

viniarck commented 2 months ago

@viniarck Maybe for the future we can update the start and end date sections for maintenance so that users don't have to type in a date in such a format and in UTC. image

Yes, if you have usability suggestions to improve, by all means, feel free to open a issue for discussion for us to eventually implement. Do you mean something like a datetime picker or something else? Let's continue that discussion in the issue.

I'll go ahead and ship this PR here. Thanks, Heriberto.