search

kytos-ng / maintenance

Kytos Maintenance Window NApp
https://kytos-ng.github.io/api/maintenance.html
0 stars 8 forks source link

Old events in the README are discontinued and new events are not mentioned #98

Closed Auwate closed 2 weeks ago

Auwate commented 1 month ago

Context

The README file mentions the event kytos/maintenance.(start|end)_(switch|uni|link}. However, this event was discontinued on 2023-06-26 in the CHANGELOG in favor of topology.interruption.[start|end]. Please update the README to reflect new changes to events.

Additional Information

This is where the CHANGELOG mentions the event:

[2023.1.0] - 2023-06-26
***********************

Added
...

Fixed
...

Changed
=======
- Maintenance start and end no longer produce ``kytos/maintenance.*`` events, and instead produce ``topology.interruption.[start|end]`` events to work with blueprint EP0037
- Creating a maintenance window now checks if all devs exist and rejects the window, except when the attribute ``ignore_no_exists`` is set to True
viniarck commented 1 month ago

Good finding @Auwate. Yes, it needs to be removed from the README.

Auwate commented 3 weeks ago

Thanks @viniarck. Would you like me to create an MR on this one?

viniarck commented 3 weeks ago

Thanks @viniarck. Would you like me to create an MR on this one?

@Auwate much appreciated if you can send a PR updating it. Otherwise, I can do it in the next days too.

Auwate commented 2 weeks ago

@viniarck Here is the MR: https://github.com/kytos-ng/maintenance/issues/98