search

kytos-ng / of_core

Kytos Main OpenFlow Network Application (NApp)
MIT License
0 stars 5 forks source link

`tox` v4 is failing in the CI #93

Closed viniarck closed 1 year ago

viniarck commented 1 year ago

We've got tox v3 pinned on our dependencies but on scrutinizer it was not pinned, so it's fetching and installing the new released tox v4, which seems to be a brand new rewrite with certain breaking changes mentioned in the changelog:

Collecting tox
  Downloading tox-4.0.2-py3-none-any.whl (140 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 140.8/140.8 kB 8.9 MB/s eta 0:00:00
25hCollecting coverage
  Downloading coverage-6.5.0-cp39-cp39-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl (212 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 212.8/212.8 kB 33.8 MB/s eta 0:00:00

^ logs from this PR that I've just opened #92

So, this task is to update scrtunizer python 3.9 global config and pin tox to 3.27.1 to see if continue to work, and then we can decide when we'll upgrade tox to v4.

viniarck commented 1 year ago

Pinning to 3.27.1 worked, see this execution on Scrutinizer

I'll close this issue, and then I mapped a new issue to potentially consider when we should try to upgrade to v4