kytos-ng / of_core

Kytos Main OpenFlow Network Application (NApp)
MIT License
0 stars 5 forks source link

Tox: unrecognized arguments: -Urrequirements/dev.txt for tox env py within deps #94

Closed italovalcy closed 1 year ago

italovalcy commented 1 year ago

Hi,

On the daily unit tests we got this error (of_core was just one of the failed repos, many others failed as well):

96 $ tox
97 py39: failed with unrecognized arguments: -Urrequirements/dev.txt for tox env py within deps
98 py39: FAIL ✖ in 0.6 seconds
99 coverage: recreate env because env type changed from {'name': 'py39', 'type': 'VirtualEnvRunner'} to {'name': 'coverage', 'type': 'VirtualEnvRunner'}
100 coverage: remove tox env folder /builds/kytos/of_core/of_core/.tox/py39
101 coverage: failed with unrecognized arguments: -Urrequirements/dev.txt for tox env py within deps
102 coverage: FAIL ✖ in 0.3 seconds

It looks like tox was upgraded to 4.x a few days ago and ever since the upgrade we are seeing the error above.

Any suggestions on this problem? Last working version was based on tox==3.27.1

viniarck commented 1 year ago

@italovalcy, yes, on Scrutinizer global config for py39 unit tests we've pinned 3.27.1 #93

On NApps requirements/dev.txt all frozen tox versions are on 3.X, so as long as whichever CI doesn't install upfront tox v4 that should still work. Could you try to pin 3.27.1 on GitLab CI pip install?

FYI, the other day I captured this issue https://github.com/kytos-ng/kytos/issues/313 to assess when we'll support tox v4, but since it'll horizontally need to regenerate dev deps and update tox.ini files that won't likely be prioritized this or next month (when we prioritize this let's take to opportunity to also do any other dev related upgrade like pytest (issue https://github.com/kytos-ng/kytos/issues/302) and so on as well to take advantage).

italovalcy commented 1 year ago

@italovalcy, yes, on Scrutinizer global config for py39 unit tests we've pinned 3.27.1 #93

On NApps requirements/dev.txt all frozen tox versions are on 3.X, so as long as whichever CI doesn't install upfront tox v4 that should still work. Could you try to pin 3.27.1 on GitLab CI pip install?

FYI, the other day I captured this issue kytos-ng/kytos#313 to assess when we'll support tox v4, but since it'll horizontally need to regenerate dev deps and update tox.ini files that won't likely be prioritized this or next month (when we prioritize this let's take to opportunity to also do any other dev related upgrade like pytest (issue kytos-ng/kytos#302) and so on as well to take advantage).

Hi @viniarck, thanks for providing the references! I've pinned the tox version to 3.27.1 and the tests worked as expected.

Closing the issue.