Ktmi
commented
2 months ago @viniarck Added in the E2E results. Not sure what the cause of the error with flow stats was. I'll be rerunning without this patch enabled to see if this patch is the cause.
Closed Ktmi closed 2 months ago
Ktmi
commented
2 months ago @viniarck Added in the E2E results. Not sure what the cause of the error with flow stats was. I'll be rerunning without this patch enabled to see if this patch is the cause.
Ktmi
commented
2 months ago Rerunning wihtout the patch results in the failing flow stats tests to no longer fail:
kytos_1 | Starting enhanced syslogd: rsyslogd.
kytos_1 | /etc/openvswitch/conf.db does not exist ... (warning).
kytos_1 | Creating empty database /etc/openvswitch/conf.db.
kytos_1 | Starting ovsdb-server.
kytos_1 | Configuring Open vSwitch system IDs.
kytos_1 | Starting ovs-vswitchd.
kytos_1 | Enabling remote OVSDB managers.
kytos_1 | + '[' -z '' ']'
kytos_1 | + '[' -z '' ']'
kytos_1 | + echo 'There is no NAPPS_PATH specified. Default will be used.'
kytos_1 | + NAPPS_PATH=
kytos_1 | There is no NAPPS_PATH specified. Default will be used.
kytos_1 | + sed -i 's/STATS_INTERVAL = 60/STATS_INTERVAL = 7/g' /var/lib/kytos/napps/kytos/of_core/settings.py
kytos_1 | + sed -i 's/CONSISTENCY_MIN_VERDICT_INTERVAL =.*/CONSISTENCY_MIN_VERDICT_INTERVAL = 60/g' /var/lib/kytos/napps/kytos/flow_manager/settings.py
kytos_1 | + sed -i 's/LINK_UP_TIMER = 10/LINK_UP_TIMER = 1/g' /var/lib/kytos/napps/kytos/topology/settings.py
kytos_1 | + sed -i 's/DEPLOY_EVCS_INTERVAL = 60/DEPLOY_EVCS_INTERVAL = 5/g' /var/lib/kytos/napps/kytos/mef_eline/settings.py
kytos_1 | + sed -i 's/LLDP_LOOP_ACTIONS = \["log"\]/LLDP_LOOP_ACTIONS = \["disable","log"\]/' /var/lib/kytos/napps/kytos/of_lldp/settings.py
kytos_1 | + sed -i 's/LLDP_IGNORED_LOOPS = {}/LLDP_IGNORED_LOOPS = {"00:00:00:00:00:00:00:01": \[\[4, 5\]\]}/' /var/lib/kytos/napps/kytos/of_lldp/settings.py
kytos_1 | + sed -i 's/CONSISTENCY_COOKIE_IGNORED_RANGE =.*/CONSISTENCY_COOKIE_IGNORED_RANGE = [(0xdd00000000000000, 0xdd00000000000009)]/g' /var/lib/kytos/napps/kytos/flow_manager/settings.py
kytos_1 | + sed -i 's/LIVENESS_DEAD_MULTIPLIER =.*/LIVENESS_DEAD_MULTIPLIER = 3/g' /var/lib/kytos/napps/kytos/of_lldp/settings.py
kytos_1 | + kytosd --help
kytos_1 | + sed -i s/WARNING/INFO/g /etc/kytos/logging.ini
kytos_1 | + test -z ''
kytos_1 | + TESTS=tests/
kytos_1 | + test -z ''
kytos_1 | + RERUNS=2
kytos_1 | + python3 scripts/wait_for_mongo.py
kytos_1 | Trying to run hello command on MongoDB...
kytos_1 | Trying to run 'hello' command on MongoDB...
kytos_1 | Trying to run 'hello' command on MongoDB...
kytos_1 | Ran 'hello' command on MongoDB successfully. It's ready!
kytos_1 | + python3 -m pytest tests/ --reruns 2 -r fEr
kytos_1 | ============================= test session starts ==============================
kytos_1 | platform linux -- Python 3.11.2, pytest-8.1.1, pluggy-1.5.0
kytos_1 | rootdir: /tests
kytos_1 | plugins: timeout-2.2.0, rerunfailures-13.0, anyio-4.3.0
kytos_1 | collected 267 items
kytos_1 |
kytos_1 | tests/test_e2e_01_kytos_startup.py .. [ 0%]
kytos_1 | tests/test_e2e_05_topology.py .................. [ 7%]
kytos_1 | tests/test_e2e_06_topology.py .... [ 8%]
kytos_1 | tests/test_e2e_10_mef_eline.py ..........ss.....x.....x................ [ 23%]
kytos_1 | tests/test_e2e_11_mef_eline.py ...... [ 26%]
kytos_1 | tests/test_e2e_12_mef_eline.py .....Xx. [ 29%]
kytos_1 | tests/test_e2e_13_mef_eline.py ....Xs.s.....Xs.s.XXxX.xxxx..X........... [ 44%]
kytos_1 | . [ 44%]
kytos_1 | tests/test_e2e_14_mef_eline.py x [ 45%]
kytos_1 | tests/test_e2e_15_mef_eline.py ..... [ 47%]
kytos_1 | tests/test_e2e_16_mef_eline.py .. [ 47%]
kytos_1 | tests/test_e2e_20_flow_manager.py ...................... [ 56%]
kytos_1 | tests/test_e2e_21_flow_manager.py ... [ 57%]
kytos_1 | tests/test_e2e_22_flow_manager.py ............... [ 62%]
kytos_1 | tests/test_e2e_23_flow_manager.py .............. [ 68%]
kytos_1 | tests/test_e2e_30_of_lldp.py .... [ 69%]
kytos_1 | tests/test_e2e_31_of_lldp.py ... [ 70%]
kytos_1 | tests/test_e2e_32_of_lldp.py ... [ 71%]
kytos_1 | tests/test_e2e_40_sdntrace.py ................ [ 77%]
kytos_1 | tests/test_e2e_41_kytos_auth.py ........ [ 80%]
kytos_1 | tests/test_e2e_42_sdntrace.py .. [ 81%]
kytos_1 | tests/test_e2e_50_maintenance.py ............................ [ 92%]
kytos_1 | tests/test_e2e_60_of_multi_table.py ..... [ 94%]
kytos_1 | tests/test_e2e_70_kytos_stats.py ....R.R... [ 97%]
kytos_1 | tests/test_e2e_80_pathfinder.py ss...... [100%]
kytos_1 |
kytos_1 | =============================== warnings summary ===============================
kytos_1 | usr/local/lib/python3.11/dist-packages/kytos/core/config.py:254
kytos_1 | /usr/local/lib/python3.11/dist-packages/kytos/core/config.py:254: UserWarning: Unknown arguments: ['tests/', '--reruns', '2', '-r', 'fEr']
kytos_1 | warnings.warn(f"Unknown arguments: {unknown}")
kytos_1 |
kytos_1 | test_e2e_01_kytos_startup.py: 17 warnings
kytos_1 | test_e2e_05_topology.py: 17 warnings
kytos_1 | test_e2e_06_topology.py: 76 warnings
kytos_1 | test_e2e_10_mef_eline.py: 17 warnings
kytos_1 | test_e2e_11_mef_eline.py: 25 warnings
kytos_1 | test_e2e_12_mef_eline.py: 17 warnings
kytos_1 | test_e2e_13_mef_eline.py: 17 warnings
kytos_1 | test_e2e_14_mef_eline.py: 76 warnings
kytos_1 | test_e2e_15_mef_eline.py: 17 warnings
kytos_1 | test_e2e_16_mef_eline.py: 17 warnings
kytos_1 | test_e2e_20_flow_manager.py: 17 warnings
kytos_1 | test_e2e_21_flow_manager.py: 17 warnings
kytos_1 | test_e2e_22_flow_manager.py: 17 warnings
kytos_1 | test_e2e_23_flow_manager.py: 17 warnings
kytos_1 | test_e2e_30_of_lldp.py: 17 warnings
kytos_1 | test_e2e_31_of_lldp.py: 17 warnings
kytos_1 | test_e2e_32_of_lldp.py: 11 warnings
kytos_1 | test_e2e_40_sdntrace.py: 49 warnings
kytos_1 | test_e2e_41_kytos_auth.py: 17 warnings
kytos_1 | test_e2e_42_sdntrace.py: 84 warnings
kytos_1 | test_e2e_50_maintenance.py: 17 warnings
kytos_1 | test_e2e_60_of_multi_table.py: 17 warnings
kytos_1 | test_e2e_70_kytos_stats.py: 17 warnings
kytos_1 | test_e2e_80_pathfinder.py: 37 warnings
kytos_1 | /usr/lib/python3/dist-packages/mininet/node.py:1121: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
kytos_1 | return ( StrictVersion( cls.OVSVersion ) <
kytos_1 |
kytos_1 | test_e2e_01_kytos_startup.py: 17 warnings
kytos_1 | test_e2e_05_topology.py: 17 warnings
kytos_1 | test_e2e_06_topology.py: 76 warnings
kytos_1 | test_e2e_10_mef_eline.py: 17 warnings
kytos_1 | test_e2e_11_mef_eline.py: 25 warnings
kytos_1 | test_e2e_12_mef_eline.py: 17 warnings
kytos_1 | test_e2e_13_mef_eline.py: 17 warnings
kytos_1 | test_e2e_14_mef_eline.py: 76 warnings
kytos_1 | test_e2e_15_mef_eline.py: 17 warnings
kytos_1 | test_e2e_16_mef_eline.py: 17 warnings
kytos_1 | test_e2e_20_flow_manager.py: 17 warnings
kytos_1 | test_e2e_21_flow_manager.py: 17 warnings
kytos_1 | test_e2e_22_flow_manager.py: 17 warnings
kytos_1 | test_e2e_23_flow_manager.py: 17 warnings
kytos_1 | test_e2e_30_of_lldp.py: 17 warnings
kytos_1 | test_e2e_31_of_lldp.py: 17 warnings
kytos_1 | test_e2e_32_of_lldp.py: 11 warnings
kytos_1 | test_e2e_40_sdntrace.py: 49 warnings
kytos_1 | test_e2e_41_kytos_auth.py: 17 warnings
kytos_1 | test_e2e_42_sdntrace.py: 84 warnings
kytos_1 | test_e2e_50_maintenance.py: 17 warnings
kytos_1 | test_e2e_60_of_multi_table.py: 17 warnings
kytos_1 | test_e2e_70_kytos_stats.py: 17 warnings
kytos_1 | test_e2e_80_pathfinder.py: 37 warnings
kytos_1 | /usr/lib/python3/dist-packages/mininet/node.py:1122: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
kytos_1 | StrictVersion( '1.10' ) )
kytos_1 |
kytos_1 | -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
kytos_1 | ------------------------------- start/stop times -------------------------------
kytos_1 | rerun: 0
kytos_1 | test_e2e_70_kytos_stats.py::TestE2EKytosStats::test_025_packet_count_per_flow: 2024-08-30,22:20:13.169933 - 2024-08-30,22:20:13.174523
kytos_1 | self = <tests.test_e2e_70_kytos_stats.TestE2EKytosStats object at 0x7f49daff6390>
kytos_1 |
kytos_1 | def test_025_packet_count_per_flow(self):
kytos_1 | """Test packet_count_per_flow"""
kytos_1 | api_url = KYTOS_STATS + '/flow/stats?dpid=00:00:00:00:00:00:00:01'
kytos_1 | response = requests.get(api_url)
kytos_1 | assert response.status_code == 200, response.text
kytos_1 | data_flow = response.json()['00:00:00:00:00:00:00:01']
kytos_1 |
kytos_1 | api_url = KYTOS_STATS + '/packet_count/per_flow/00:00:00:00:00:00:00:01'
kytos_1 | response = requests.get(api_url)
kytos_1 | assert response.status_code == 200, response.text
kytos_1 | data = response.json()
kytos_1 | for info_flow in data:
kytos_1 | flow_id = info_flow['flow_id']
kytos_1 | count = data_flow[flow_id]['packet_count']
kytos_1 | assert info_flow['packet_counter'] == count
kytos_1 | > assert info_flow['packet_per_second'] == count/data_flow[flow_id]['duration_sec']
kytos_1 | E ZeroDivisionError: division by zero
kytos_1 |
kytos_1 | tests/test_e2e_70_kytos_stats.py:233: ZeroDivisionError
kytos_1 | rerun: 0
kytos_1 | test_e2e_70_kytos_stats.py::TestE2EKytosStats::test_030_bytes_count_per_flow: 2024-08-30,22:20:56.937566 - 2024-08-30,22:20:56.942318
kytos_1 | self = <tests.test_e2e_70_kytos_stats.TestE2EKytosStats object at 0x7f49daff6a10>
kytos_1 |
kytos_1 | def test_030_bytes_count_per_flow(self):
kytos_1 | """Test bytes_count_per_flow"""
kytos_1 |
kytos_1 | api_url = KYTOS_STATS + '/flow/stats?dpid=00:00:00:00:00:00:00:01'
kytos_1 | response = requests.get(api_url)
kytos_1 | assert response.status_code == 200, response.text
kytos_1 | data_flow = response.json()['00:00:00:00:00:00:00:01']
kytos_1 |
kytos_1 | api_url = KYTOS_STATS + '/bytes_count/per_flow/00:00:00:00:00:00:00:01'
kytos_1 | response = requests.get(api_url)
kytos_1 | assert response.status_code == 200, response.text
kytos_1 | data = response.json()
kytos_1 | for info_flow in data:
kytos_1 | flow_id = info_flow['flow_id']
kytos_1 | count = data_flow[flow_id]['byte_count']
kytos_1 | assert info_flow['bytes_counter'] == count
kytos_1 | > assert info_flow['bits_per_second'] == 8 * count/data_flow[flow_id]['duration_sec']
kytos_1 | E ZeroDivisionError: division by zero
kytos_1 |
kytos_1 | tests/test_e2e_70_kytos_stats.py:252: ZeroDivisionError
kytos_1 | =========================== rerun test summary info ============================
kytos_1 | RERUN test_e2e_70_kytos_stats.py::TestE2EKytosStats::test_025_packet_count_per_flow
kytos_1 | RERUN test_e2e_70_kytos_stats.py::TestE2EKytosStats::test_030_bytes_count_per_flow
kytos_1 | = 243 passed, 8 skipped, 9 xfailed, 7 xpassed, 1295 warnings, 2 rerun in 10873.40s (3:01:13) =
kytos-tests_kytos_1 exited with code 0
viniarck
commented
2 months ago @Ktmi, good to know.
Regarding the failed tests, yes, they don't look related to this change here. But, these two tests can be slightly improved, no need to do it in this PR, but let's map an issue on e2e repo to try to increase the delay for these two tests. I suspect it might be a case where locally mininet/OvS gets slightly overloaded, doesn't reply the stats in time, and then since the test expects the data it crashes. So, a larger delay value might be good enough as a temporary fix for them:
kytos_1 | RERUN test_e2e_70_kytos_stats.py::TestE2EKytosStats::test_025_packet_count_per_flow
kytos_1 | RERUN test_e2e_70_kytos_stats.py::TestE2EKytosStats::test_030_bytes_count_per_flow@viniarck Bumped up the version number in kytos.json and changelog.rst
viniarck
commented
2 months ago @viniarck Bumped up the version number in kytos.json and changelog.rst
Great. Let's ship it.
Closes #39
Summary
Adds in the owner when deleting flows.
Local Tests
Seems to work fine.
End-to-End Tests
Ran end to end tests, here is the test report:
I'm getting some errors here with flow stats, and I'm not sure if its a change here that's the cause.