kytos-ng / telemetry_int

Kytos Telemetry Napp
MIT License
0 stars 2 forks source link

refactor: only support bidirectional EVCs for now #34

Closed viniarck closed 10 months ago

viniarck commented 10 months ago

To quote it from https://github.com/kytos-ng/kytos/pull/402/files:

  • Currently, EVCs are always bidirectional. telemetry_int v1 iteration, will also follow the bidirectional flows as described in the prior sections. In the future, when mef_eline starts to support unidirectional flows, then following the flows should be mostly seamless, this facilitates implementation and code maintenance without having to try to derive the direction of all flows and maintain a structure that mef_eline still doesn't support.

Originally, telemetry_int implementation tried to anticipate and be flexible enough for being unidirectional (including being unidirectional as a best effort if only a single loop was configured), but it adds more complexity and code to maintain. The easiest and most maintainable route, without surprises whether or unidirectional/bidirectional loops are configured too, is to piggyback to the direction of the EVC, and in the future, seamlessly or with minor adjustments also support unidirectional ones, if unidirectional EVCs is ever supported by mef_eline (this is also being analyzed too on version 2023.2 on issue https://github.com/kytos-ng/mef_eline/issues/362). This is issue here still being discussed (although it's been already partly approved), I'll go ahead and map this issue, just so I can point it out in a subsequent PR. Jeronimo will also review the linked PR and the augmented requirements, just so we're on the same page.