search

kytos-ng / topology

Kytos Main Topology Network Application (NApp)
https://kytos-ng.github.io/api/topology.html
MIT License
0 stars 7 forks source link

backport: `kytos/.*.uni_available_tags` to update UNI tags in interfaces #169

Closed Alopalao closed 11 months ago

Alopalao commented 11 months ago

Closes #165

Summary

The base branch is base/2023.1.0, It is what we have on releases. Added kytos/.*.uni_available_tags so Interface.available_tags is updated in the DB when a UNI tag is allocated

Local Tests

Added uni tests Created EVCs and see allocated vlan from interfaces.

End-To-End Tests

Results in mef_eline PR

viniarck commented 11 months ago

Nicely done @Alopalao. Also, appreciated you making the DB script safer.

Feel free to merge this into base/2023.1.1 and then create a GitHub release targeting base/2023.1.1 (also creating the git tag accordingly), if you need help let me know (also feel free to do the same for kytos-ng/mef_eline#381). Other than that, I'll encourage you that you also run this script against prod copied/dumped data that you spoke with Italo on the weekly meeting. Since you're at it, it might be worth to take the opportunity to also run vlan_pool.py DB script in that prod copied data, even though it's not related to this PR. Thanks, Aldo.

@Alopalao I realize you're progressing with vlan range and other PRs, but following up here, did you have the chance to also run the script with copied prod data? If positive and it's passing feel free to merge and push the tag on GitHub. If you need my help to also merge or tag upstream let me know. Thanks.

Alopalao commented 11 months ago

I have not received the copied data, but I tested with one created by following e2e tests examples. The updated script worked with failover_path and current_path.

viniarck commented 11 months ago

I have not received the copied data, but I tested with one created by following e2e tests examples. The updated script worked with failover_path and current_path.

OK. Good to know @Alopalao. I'll go ahead and merge this PR. Regarding the prod data, it won't be a blocker, since it looks good and you locally tested it with other data, but please map a task for trying out all scripts with prod data, it'd be helpful for @italovalcy to also have this feedback. In the future, we do plan to have e2e tests with equivalent prod data in terms of scalability, but until then for certain cases core developers still need to also explore them. Thanks.