Closed Alopalao closed 7 months ago
Pushed an unfinished but working state of switch deletion. Going to continue working after I return from the holidays.
End-To-End Tests results:
tests/test_e2e_01_kytos_startup.py .. [ 0%]
tests/test_e2e_05_topology.py ......FFFF......... [ 8%]
tests/test_e2e_10_mef_eline.py ..........ss.....x.....x................ [ 23%]
tests/test_e2e_11_mef_eline.py ...... [ 26%]
tests/test_e2e_12_mef_eline.py .....Xx. [ 29%]
tests/test_e2e_13_mef_eline.py ....Xs.s.....Xs.s.XXxX.xxxx..X........... [ 45%]
. [ 45%]
tests/test_e2e_14_mef_eline.py x [ 46%]
tests/test_e2e_15_mef_eline.py ..... [ 48%]
tests/test_e2e_20_flow_manager.py ..................... [ 56%]
tests/test_e2e_21_flow_manager.py ... [ 57%]
tests/test_e2e_22_flow_manager.py ............... [ 63%]
tests/test_e2e_23_flow_manager.py .............. [ 69%]
tests/test_e2e_30_of_lldp.py ..F. [ 70%]
tests/test_e2e_31_of_lldp.py ... [ 71%]
tests/test_e2e_32_of_lldp.py ... [ 72%]
tests/test_e2e_40_sdntrace.py .............. [ 78%]
tests/test_e2e_41_kytos_auth.py ........ [ 81%]
tests/test_e2e_42_sdntrace.py .. [ 82%]
tests/test_e2e_50_maintenance.py ........................ [ 91%]
tests/test_e2e_60_of_multi_table.py ..... [ 93%]
tests/test_e2e_70_kytos_stats.py ........ [ 96%]
tests/test_e2e_80_pathfinder.py ........ [100%]
The failures are fixed in PR #277
Following this comment.
Commit 13657265f894a87a99b51dd2eec1ec7208828ddc
Now it is implemented a clear hierarchy:
Now enabling a component will be "private". For example enabling an interface will not enable a link (when both endpoints are enabled as a result).
With this change there may be some changes to kytos.core
as well. Considering all components derive from common.Generic:
_enabled
always going to reflect this state correctly. Checking endpoints seems unnecessary. But, this method is not problematic at all and we could leave as it is.New e2e results:
============================= test session starts ==============================
platform linux -- Python 3.9.2, pytest-7.2.0, pluggy-1.3.0
rootdir: /tests
plugins: timeout-2.1.0, rerunfailures-10.2, anyio-3.6.2
collected 256 items
tests/test_e2e_01_kytos_startup.py .. [ 0%]
tests/test_e2e_05_topology.py ...............RRF.... [ 8%]
tests/test_e2e_10_mef_eline.py ..........ss.....x.....x................ [ 24%]
tests/test_e2e_11_mef_eline.py ...... [ 26%]
tests/test_e2e_12_mef_eline.py .....Xx. [ 29%]
tests/test_e2e_13_mef_eline.py ....Xs.s.....Xs.s.XXxX.xxxx..X........... [ 45%]
. [ 46%]
tests/test_e2e_14_mef_eline.py x [ 46%]
tests/test_e2e_15_mef_eline.py ..... [ 48%]
tests/test_e2e_20_flow_manager.py ..................... [ 56%]
tests/test_e2e_21_flow_manager.py ... [ 57%]
tests/test_e2e_22_flow_manager.py ............... [ 63%]
tests/test_e2e_23_flow_manager.py .............. [ 69%]
tests/test_e2e_30_of_lldp.py .... [ 70%]
tests/test_e2e_31_of_lldp.py ... [ 71%]
tests/test_e2e_32_of_lldp.py ... [ 73%]
tests/test_e2e_40_sdntrace.py .............. [ 78%]
tests/test_e2e_41_kytos_auth.py ........ [ 81%]
tests/test_e2e_42_sdntrace.py .. [ 82%]
tests/test_e2e_50_maintenance.py ........................ [ 91%]
tests/test_e2e_60_of_multi_table.py ..... [ 93%]
tests/test_e2e_70_kytos_stats.py ........ [ 96%]
tests/test_e2e_80_pathfinder.py ss...... [100%]
Topology error fixed in new commit from PR
let me know you've also explored it locally one last time with the latest changes
Yes, I have tested the new enable dynamics. The UI helped speeding it up.
let me know you've also explored it locally one last time with the latest changes
Yes, I have tested the new enable dynamics. The UI helped speeding it up.
Excellent. Let's ship this then.
Closes #164 Closes #77 Closes #76
Summary
Added endpoint to delete switch. Requirements:
DISABLED
.To clean left-over flows related to switch, related links should be disabled. Needs
coloring
PR #59Changed how enabling/disabling components work. It is better explained in this comment.
Local Tests
Deleted disabled switch
End-To-End Tests
The failures are fixed in PR #277