search

kytos-ng / ui

Kytos Admin UI
MIT License
0 stars 3 forks source link

Replace httpvueloader with vue3-sfc-loader #109

Open HeriLFIU opened 1 month ago

HeriLFIU commented 1 month ago

Closes #issue_number

Summary

Replaced httpvueloader with vue3-sfc-loader.

Mef-eline was trying to access and change the value of a prop within k-accordion-item through references, and props are read only. Because of this, the prop was switched for a data element since no component was using the prop functionality and the data element can be modified.

Mef-eline was trying to give the prop named value from k-input an integer value. This prop was typed and expected a string; because of this, the type specification was removed from the prop, and now it can accept any value.

Enabled the ability to disable k-input for text display purposes only.

Local Tests

To test the new additions all of the UI elements were used.

Note

k-info-panels are disabled (commented out), since they have not yet been incorporated with the changes. Replace .kytos file extension with .vue. Incorporate changes from drafts in other napps for vue3-sfc-loader compatibility.

HeriLFIU commented 1 month ago

@viniarck I just finished testing all of the k-toolbars, and they are now functioning properly. There's a small error that I fixed, but it was a bit hard to detect. I believe that I got them all, but there is a change that I missed a couple, and unless explicitly used, it won't pop up. The error is that variables now need to be properly declared using either let or var; if not, the vue3-sfc-loader will throw an error. A lot of variables were missing that let/var.

HeriLFIU commented 1 month ago

But I went through all the buttons and inputs and it didn't show up again, so I think that the k-toolbars are in the clear.

HeriLFIU commented 3 weeks ago

@viniarck Yep, I am handling them in the individual PRs for each napp.

HeriLFIU commented 3 weeks ago

@viniarck Also, the k-toolbars only had a few errors, which meant they were easy to fix, but the CSS for some of the info panels seems to break for some reason, and I'm trying to find out why.

viniarck commented 2 weeks ago

@viniarck Yep, I am handling them in the individual PRs for each napp.

Excellent. The ones that could've got merged and wouldn't break anything I went ahead and merged them.

When this PR here is ready for review, I recommend you to also list in the description the other depends PR/issues that also need to land just so we make sure to merge them all together, to avoid potentially leaving something behind or potentially broken on master branch.

viniarck commented 2 weeks ago

@viniarck Also, the k-toolbars only had a few errors, which meant they were easy to fix, but the CSS for some of the info panels seems to break for some reason, and I'm trying to find out why.

Right.