kytos-ng / ui

Kytos Admin UI
MIT License
0 stars 3 forks source link

Added buttons to modify interface metadata #25

Closed Alopalao closed 2 years ago

Alopalao commented 2 years ago

Base on issue #15 Added buttons to add or remove metadata from an interface. Update: -It needs the topology PR #85

viniarck commented 2 years ago

@Alopalao this PR looks good to me, let's bump version 2022.2.0.b2 for it, could you update the changelog and version accordingly? Make sure also to merge master into this branch and solve the conflict, thanks.

Also, another related thing that I've noticed is that the interface details panel currently is getting mounted maximized by default (it's not a side effect of this PR), but I wonder if we should make it not maximized by default, looking in the git history I don't see a particular reason why, and having it not maximized it would make a smoother transition when selecting and mounting the component. @rmotitsuki and @Alopalao any thoughts or suggestions on that, wdyt?

2022-04-11-171457_918x688_scrot

2022-04-11-172832_437x685_scrot

Alopalao commented 2 years ago

I think it would be better to change it back to false to keep a theme of opening minimized information panels.

Alopalao commented 2 years ago

Updated changelog.rst on commit cc18643c47ac503a057a2e2f0a6de9c83e0e7d16

viniarck commented 2 years ago

NPM build command gives me an error for the version format. The version must be in the format 2022.2.0-b2

@Alopalao let's take the opportunity to leave the interface details minized then too, could you also update that part? Also, apologies for the wrong version format that I specified, let's stick with this one 2022.2.0-b2 that @rmotitsuki suggested just it still compatible with other npm versions.

Thanks, guys.

Alopalao commented 2 years ago

Maximization option and version updated on commit e0106870698a81c402978fac5feb583ed4bea53b

viniarck commented 2 years ago

Maximization option and version updated on commit e0106870698a81c402978fac5feb583ed4bea53b

Excellent. Let's ship this feature, appreciated your contribution @Alopalao.